Uploaded image for project: 'Apache NiFi'
  1. Apache NiFi
  2. NIFI-3809

S2S Reporting tasks should provide the option to choose transport protocol

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.2.0
    • Fix Version/s: 1.3.0
    • Component/s: Extensions
    • Labels:
      None

      Description

      Right now Site-to-Site based reporting tasks are using the default RAW protocol but some users might not want to open a port for that. It should be possible to use HTTP.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user pvillard31 opened a pull request:

          https://github.com/apache/nifi/pull/1754

          NIFI-3809 - Added HTTP mode and HTTP proxy for S2S Reporting Tasks

          Thank you for submitting a contribution to Apache NiFi.

          In order to streamline the review of the contribution we ask you
          to ensure the following steps have been taken:

              1. For all changes:
          • [X] Is there a JIRA ticket associated with this PR? Is it referenced
            in the commit message?
          • [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
          • [X] Has your PR been rebased against the latest commit within the target branch (typically master)?
          • [X] Is your initial contribution a single, squashed commit?
              1. For code changes:
          • [X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
          • [X] Have you written or updated unit tests to verify your changes?
          • [X] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
              1. Note:
                Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/pvillard31/nifi NIFI-3809

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/nifi/pull/1754.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #1754


          commit c077a3da893f5c56e505bc1c94f51c8f2fc30ecf
          Author: Pierre Villard <pierre.villard.fr@gmail.com>
          Date: 2017-05-04T20:43:32Z

          NIFI-3809 - Added HTTP mode and HTTP proxy for S2S Reporting Tasks


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/1754 NIFI-3809 - Added HTTP mode and HTTP proxy for S2S Reporting Tasks Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: For all changes: [X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. [X] Has your PR been rebased against the latest commit within the target branch (typically master)? [X] Is your initial contribution a single, squashed commit? For code changes: [X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? [X] Have you written or updated unit tests to verify your changes? [X] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/pvillard31/nifi NIFI-3809 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1754.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1754 commit c077a3da893f5c56e505bc1c94f51c8f2fc30ecf Author: Pierre Villard <pierre.villard.fr@gmail.com> Date: 2017-05-04T20:43:32Z NIFI-3809 - Added HTTP mode and HTTP proxy for S2S Reporting Tasks
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user ijokarumawak commented on the issue:

          https://github.com/apache/nifi/pull/1754

          Reviewing...

          Show
          githubbot ASF GitHub Bot added a comment - Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1754 Reviewing...
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user ijokarumawak commented on a diff in the pull request:

          https://github.com/apache/nifi/pull/1754#discussion_r118202031

          — Diff: nifi-nar-bundles/nifi-site-to-site-reporting-bundle/nifi-site-to-site-reporting-task/src/main/java/org/apache/nifi/reporting/AbstractSiteToSiteReportingTask.java —
          @@ -73,25 +80,65 @@
          .build();
          static final PropertyDescriptor COMPRESS = new PropertyDescriptor.Builder()
          .name("Compress Events")
          + .displayName("Compress Events")
          .description("Indicates whether or not to compress the data being sent.")
          .required(true)
          .allowableValues("true", "false")
          .defaultValue("true")
          .build();
          static final PropertyDescriptor TIMEOUT = new PropertyDescriptor.Builder()
          .name("Communications Timeout")
          + .displayName("Communications Timeout")
          .description("Specifies how long to wait to a response from the destination before deciding that an error has occurred and canceling the transaction")
          .required(true)
          .defaultValue("30 secs")
          .addValidator(StandardValidators.TIME_PERIOD_VALIDATOR)
          .build();
          static final PropertyDescriptor BATCH_SIZE = new PropertyDescriptor.Builder()
          .name("Batch Size")
          + .displayName("Batch Size")
          .description("Specifies how many records to send in a single batch, at most.")
          .required(true)
          .defaultValue("1000")
          .addValidator(StandardValidators.POSITIVE_INTEGER_VALIDATOR)
          .build();
          + static final PropertyDescriptor TRANSPORT_PROTOCOL = new PropertyDescriptor.Builder()
          — End diff –

          If I am not missing anything, these newly added PropertyDescriptors should be used by sub classes such as SiteToSiteBulletinReportingTask?

          Show
          githubbot ASF GitHub Bot added a comment - Github user ijokarumawak commented on a diff in the pull request: https://github.com/apache/nifi/pull/1754#discussion_r118202031 — Diff: nifi-nar-bundles/nifi-site-to-site-reporting-bundle/nifi-site-to-site-reporting-task/src/main/java/org/apache/nifi/reporting/AbstractSiteToSiteReportingTask.java — @@ -73,25 +80,65 @@ .build(); static final PropertyDescriptor COMPRESS = new PropertyDescriptor.Builder() .name("Compress Events") + .displayName("Compress Events") .description("Indicates whether or not to compress the data being sent.") .required(true) .allowableValues("true", "false") .defaultValue("true") .build(); static final PropertyDescriptor TIMEOUT = new PropertyDescriptor.Builder() .name("Communications Timeout") + .displayName("Communications Timeout") .description("Specifies how long to wait to a response from the destination before deciding that an error has occurred and canceling the transaction") .required(true) .defaultValue("30 secs") .addValidator(StandardValidators.TIME_PERIOD_VALIDATOR) .build(); static final PropertyDescriptor BATCH_SIZE = new PropertyDescriptor.Builder() .name("Batch Size") + .displayName("Batch Size") .description("Specifies how many records to send in a single batch, at most.") .required(true) .defaultValue("1000") .addValidator(StandardValidators.POSITIVE_INTEGER_VALIDATOR) .build(); + static final PropertyDescriptor TRANSPORT_PROTOCOL = new PropertyDescriptor.Builder() — End diff – If I am not missing anything, these newly added PropertyDescriptors should be used by sub classes such as SiteToSiteBulletinReportingTask?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user pvillard31 commented on the issue:

          https://github.com/apache/nifi/pull/1754

          Hey @ijokarumawak, thanks for the review! Good catch! This reporting task is not calling ``super.getSupportedPropertyDescriptors()``... I pushed another commit to address it, let me know if you want me to squash or if you have additional comments.

          Show
          githubbot ASF GitHub Bot added a comment - Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1754 Hey @ijokarumawak, thanks for the review! Good catch! This reporting task is not calling ``super.getSupportedPropertyDescriptors()``... I pushed another commit to address it, let me know if you want me to squash or if you have additional comments.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user ijokarumawak commented on the issue:

          https://github.com/apache/nifi/pull/1754

          Thanks for the update @pvillard31 . I confirmed Proxy can be specified with all three reporting tasks. LGTM +1. I'm going to squash commits and merge into master. Thank you!

          Show
          githubbot ASF GitHub Bot added a comment - Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1754 Thanks for the update @pvillard31 . I confirmed Proxy can be specified with all three reporting tasks. LGTM +1. I'm going to squash commits and merge into master. Thank you!
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit e05005584d52b560771a0ccf2766ee9ee92b6518 in nifi's branch refs/heads/master from Pierre Villard
          [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=e050055 ]

          NIFI-3809 - Added HTTP mode and HTTP proxy for S2S Reporting Tasks

          This closes #1754.

          Signed-off-by: Koji Kawamura <ijokarumawak@apache.org>

          Show
          jira-bot ASF subversion and git services added a comment - Commit e05005584d52b560771a0ccf2766ee9ee92b6518 in nifi's branch refs/heads/master from Pierre Villard [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=e050055 ] NIFI-3809 - Added HTTP mode and HTTP proxy for S2S Reporting Tasks This closes #1754. Signed-off-by: Koji Kawamura <ijokarumawak@apache.org>
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/nifi/pull/1754

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/1754

            People

            • Assignee:
              pvillard Pierre Villard
              Reporter:
              pvillard Pierre Villard
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development