Uploaded image for project: 'Apache NiFi'
  1. Apache NiFi
  2. NIFI-3791

SiteToSiteStatusReportingTask - include back pressure data for connections

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.2.0
    • Fix Version/s: 1.3.0
    • Component/s: Extensions
    • Labels:
      None

      Description

      Two remarks while using the SiteToSiteStatusReportingTask:

      • there is a copy/paste mistake in an exception message line 182
      • back pressure information should be included when sending status of a connection

      It'll be useful to monitor connections and raise alerts when back pressure is enabled on a connection.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user pvillard31 opened a pull request:

          https://github.com/apache/nifi/pull/1745

          NIFI-3791 - added back pressure data into S2SStatusReportingTask

          Thank you for submitting a contribution to Apache NiFi.

          In order to streamline the review of the contribution we ask you
          to ensure the following steps have been taken:

              1. For all changes:
          • [X] Is there a JIRA ticket associated with this PR? Is it referenced
            in the commit message?
          • [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
          • [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
          • [X] Is your initial contribution a single, squashed commit?
              1. For code changes:
          • [X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
          • [X] Have you written or updated unit tests to verify your changes?
              1. Note:
                Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/pvillard31/nifi NIFI-3791

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/nifi/pull/1745.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #1745


          commit 9af5ca61fdc33c333be64a136afedcb78bbcfba5
          Author: Pierre Villard <pierre.villard.fr@gmail.com>
          Date: 2017-05-03T20:56:22Z

          NIFI-3791 - added back pressure data into S2SStatusReportingTask


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/1745 NIFI-3791 - added back pressure data into S2SStatusReportingTask Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: For all changes: [X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? [X] Is your initial contribution a single, squashed commit? For code changes: [X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? [X] Have you written or updated unit tests to verify your changes? Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/pvillard31/nifi NIFI-3791 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1745.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1745 commit 9af5ca61fdc33c333be64a136afedcb78bbcfba5 Author: Pierre Villard <pierre.villard.fr@gmail.com> Date: 2017-05-03T20:56:22Z NIFI-3791 - added back pressure data into S2SStatusReportingTask
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user alopresto commented on the issue:

          https://github.com/apache/nifi/pull/1745

          Reviewing...

          Show
          githubbot ASF GitHub Bot added a comment - Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/1745 Reviewing...
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user alopresto commented on the issue:

          https://github.com/apache/nifi/pull/1745

          Ran a sample flow but was getting some odd exceptions. Coordinating with Pierre offline but recommend another party reviews this PR. As it is not going in 1.2.0, there is plenty of time to have a person with more knowledge of the internals do that.

          Show
          githubbot ASF GitHub Bot added a comment - Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/1745 Ran a sample flow but was getting some odd exceptions. Coordinating with Pierre offline but recommend another party reviews this PR. As it is not going in 1.2.0, there is plenty of time to have a person with more knowledge of the internals do that.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user ijokarumawak commented on the issue:

          https://github.com/apache/nifi/pull/1745

          @pvillard31 @alopresto I've reviewed the code, build and test the change to see if I can see any odd exceptions, but I haven't encountered any so far. I can see back-pressure status is reported properly. LGTM, +1.

          I'm going to merge this into master. Thanks for the improvement!

          Show
          githubbot ASF GitHub Bot added a comment - Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1745 @pvillard31 @alopresto I've reviewed the code, build and test the change to see if I can see any odd exceptions, but I haven't encountered any so far. I can see back-pressure status is reported properly. LGTM, +1. I'm going to merge this into master. Thanks for the improvement!
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit dc5e032368f09681bde680fc467512ea3f28dfa3 in nifi's branch refs/heads/master from Pierre Villard
          [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=dc5e032 ]

          NIFI-3791 - added back pressure data into S2SStatusReportingTask

          This closes #1745.

          Signed-off-by: Koji Kawamura <ijokarumawak@apache.org>

          Show
          jira-bot ASF subversion and git services added a comment - Commit dc5e032368f09681bde680fc467512ea3f28dfa3 in nifi's branch refs/heads/master from Pierre Villard [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=dc5e032 ] NIFI-3791 - added back pressure data into S2SStatusReportingTask This closes #1745. Signed-off-by: Koji Kawamura <ijokarumawak@apache.org>
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/nifi/pull/1745

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/1745

            People

            • Assignee:
              pvillard Pierre Villard
              Reporter:
              pvillard Pierre Villard
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development