Uploaded image for project: 'Apache NiFi'
  1. Apache NiFi
  2. NIFI-3711

Change default size of provenance details dialog to show Replay button by default

    Details

      Description

      The provenance details dialog is sized such that the "Replay" button on the "Content" tab is not visible by default and there is no visible scroll bar indicating that the panel has additional content. Some users have reported being unaware of the replay feature because of this. I propose changing the default dialog size to ensure the panel is fully displayed (min-height?).

        Activity

        Hide
        josephxsxn Joseph Niemiec added a comment -

        +1 I have had users unaware that it exists until I show them. Right now its not intuitive, this sounds more elegant.

        Show
        josephxsxn Joseph Niemiec added a comment - +1 I have had users unaware that it exists until I show them. Right now its not intuitive, this sounds more elegant.
        Hide
        scottyaslan Scott Aslan added a comment -

        Setting the min-height css property of the #event-details-dialog to 608px will 'kind of' do what you are suggesting. The issue will be that the dialogs are responsive such that if the height of the viewport is less than the 608px min-height then the dialog will ignore this rule and override the height of the dialog to only take up 100% of the available height (meaning the height of the dialog will be less than 608px on smaller screen heights)...maybe we can move the replay button somewhere else?

        Show
        scottyaslan Scott Aslan added a comment - Setting the min-height css property of the #event-details-dialog to 608px will 'kind of' do what you are suggesting. The issue will be that the dialogs are responsive such that if the height of the viewport is less than the 608px min-height then the dialog will ignore this rule and override the height of the dialog to only take up 100% of the available height (meaning the height of the dialog will be less than 608px on smaller screen heights)...maybe we can move the replay button somewhere else?
        Hide
        yuri1969 Yuri added a comment - - edited

        Using NiFi 1.3.0 and FF 55, the Content tab's overflow seems to work OK. It displays a scroll bar when the replay feature is available. Screenshot from 2017-09-10 20-56-41.png

        Show
        yuri1969 Yuri added a comment - - edited Using NiFi 1.3.0 and FF 55 , the Content tab's overflow seems to work OK. It displays a scroll bar when the replay feature is available. Screenshot from 2017-09-10 20-56-41.png
        Hide
        mcgilman Matt Gilman added a comment -

        Is part of the issue/confusion due to OS specific scrollbar policies? I know in OSX that you can configure the conditions under which scrollbars are displayed ('When scrolling', 'Always', etc). I believe this configuration can even override our CSS rules.

        Show
        mcgilman Matt Gilman added a comment - Is part of the issue/confusion due to OS specific scrollbar policies? I know in OSX that you can configure the conditions under which scrollbars are displayed ('When scrolling', 'Always', etc). I believe this configuration can even override our CSS rules.
        Hide
        yuri1969 Yuri added a comment -

        Matt Gilman Interesting. Just for the record, my testing was done on Gentoo/GNOME3.

        Show
        yuri1969 Yuri added a comment - Matt Gilman Interesting. Just for the record, my testing was done on Gentoo/GNOME3.
        Hide
        scottyaslan Scott Aslan added a comment -

        Yea, the issue is not being able to scroll to the replay button. The issue is that you may not know the replay button exists because it is not visible unless the user knows to scroll to it.

        Show
        scottyaslan Scott Aslan added a comment - Yea, the issue is not being able to scroll to the replay button. The issue is that you may not know the replay button exists because it is not visible unless the user knows to scroll to it.

          People

          • Assignee:
            Unassigned
            Reporter:
            alopresto Andy LoPresto
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:

              Development