Uploaded image for project: 'Apache NiFi'
  1. Apache NiFi
  2. NIFI-3626

Support DELETE verb for ConvertJSONToSQL

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.2.0
    • Component/s: Extensions
    • Labels:
      None

      Description

      ConvertJSONToSQL supports INSERT and UPDATE verbs (and if NIFI-991 is implemented, the UPSERT verb), but it would be helpful in use cases such as Change Data Capture and Database Migration to be able to generate DELETE statements.

      I believe this would entail generating a conjunctive (aka AND) WHERE clause, using the sql.args attributes for the prepared statement.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user mattyb149 opened a pull request:

          https://github.com/apache/nifi/pull/1605

          NIFI-3626: Add support for DELETE in ConvertJSONToSQL

          Thank you for submitting a contribution to Apache NiFi.

          In order to streamline the review of the contribution we ask you
          to ensure the following steps have been taken:

              1. For all changes:
          • [x] Is there a JIRA ticket associated with this PR? Is it referenced
            in the commit message?
          • [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
          • [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
          • [x] Is your initial contribution a single, squashed commit?
              1. For code changes:
          • [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
          • [x] Have you written or updated unit tests to verify your changes?
          • [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
          • [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
          • [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
          • [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
              1. For documentation related changes:
          • [x] Have you ensured that format looks appropriate for the output in which it is rendered?
              1. Note:
                Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/mattyb149/nifi NIFI-3626

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/nifi/pull/1605.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #1605


          commit 326c355062fd2361e49770ae61c850258a476845
          Author: Matt Burgess <mattyb149@apache.org>
          Date: 2017-03-20T19:05:46Z

          NIFI-3626: Add support for DELETE in ConvertJSONToSQL


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user mattyb149 opened a pull request: https://github.com/apache/nifi/pull/1605 NIFI-3626 : Add support for DELETE in ConvertJSONToSQL Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: For all changes: [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. [x] Has your PR been rebased against the latest commit within the target branch (typically master)? [x] Is your initial contribution a single, squashed commit? For code changes: [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? [x] Have you written or updated unit tests to verify your changes? [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0] ( http://www.apache.org/legal/resolved.html#category-a)? [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? For documentation related changes: [x] Have you ensured that format looks appropriate for the output in which it is rendered? Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mattyb149/nifi NIFI-3626 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1605.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1605 commit 326c355062fd2361e49770ae61c850258a476845 Author: Matt Burgess <mattyb149@apache.org> Date: 2017-03-20T19:05:46Z NIFI-3626 : Add support for DELETE in ConvertJSONToSQL
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user bbende commented on the issue:

          https://github.com/apache/nifi/pull/1605

          +1 looks good, was able to use ConvertJsonToSQL + PutSQL to delete records from a MySQL table. I'll merge to master.

          Show
          githubbot ASF GitHub Bot added a comment - Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1605 +1 looks good, was able to use ConvertJsonToSQL + PutSQL to delete records from a MySQL table. I'll merge to master.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit c4d0c0bbd18759100641d0cbca0b584f8f20a813 in nifi's branch refs/heads/master from Matt Burgess
          [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=c4d0c0b ]

          NIFI-3626: Add support for DELETE in ConvertJSONToSQL

          This closes #1605.

          Signed-off-by: Bryan Bende <bbende@apache.org>

          Show
          jira-bot ASF subversion and git services added a comment - Commit c4d0c0bbd18759100641d0cbca0b584f8f20a813 in nifi's branch refs/heads/master from Matt Burgess [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=c4d0c0b ] NIFI-3626 : Add support for DELETE in ConvertJSONToSQL This closes #1605. Signed-off-by: Bryan Bende <bbende@apache.org>
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/nifi/pull/1605

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/1605

            People

            • Assignee:
              mattyb149 Matt Burgess
              Reporter:
              mattyb149 Matt Burgess
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development