Uploaded image for project: 'Apache NiFi'
  1. Apache NiFi
  2. NIFI-3439

Making password property in HiveConnectionPool a hidden show.

    Details

    • Type: Bug
    • Status: Patch Available
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 1.1.1
    • Fix Version/s: None
    • Component/s: Core UI
    • Environment:
      Google Chrome browser
    • Flags:
      Patch, Important

      Description

      When user types the password in the password attribute in hive connection pool controller service, the characters are visible. Once completed the password is encrypted and no longer visible.

      shouldn't be me made as normal hidden show password box ?

      The user always has the option to delete the controller service and re-configure if he has entered a wrong password.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user scottyaslan opened a pull request:

          https://github.com/apache/nifi/pull/1546

          NIFI-3439 when users type into sensitive property fields in NiFI, t…

          …he values on the screen/browser should be masked *** unless specified by user to show plain text.

          Thank you for submitting a contribution to Apache NiFi.

          In order to streamline the review of the contribution we ask you
          to ensure the following steps have been taken:

              1. For all changes:
          • [ ] Is there a JIRA ticket associated with this PR? Is it referenced
            in the commit message?
          • [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
          • [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
          • [ ] Is your initial contribution a single, squashed commit?
              1. For code changes:
          • [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
          • [ ] Have you written or updated unit tests to verify your changes?
          • [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
          • [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
          • [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
          • [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
              1. For documentation related changes:
          • [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
              1. Note:
                Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/scottyaslan/nifi NIFI-3439

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/nifi/pull/1546.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #1546


          commit efade07d5ea39229073124bb8dd96b08387aabd7
          Author: Scott Aslan <scottyaslan@gmail.com>
          Date: 2017-02-27T17:19:05Z

          NIFI-3439 when users type into sensitive property fields in NiFI, the values on the screen/browser should be masked *** unless specified by user to show plain text.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user scottyaslan opened a pull request: https://github.com/apache/nifi/pull/1546 NIFI-3439 when users type into sensitive property fields in NiFI, t… …he values on the screen/browser should be masked *** unless specified by user to show plain text. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: For all changes: [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? [ ] Is your initial contribution a single, squashed commit? For code changes: [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? [ ] Have you written or updated unit tests to verify your changes? [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0] ( http://www.apache.org/legal/resolved.html#category-a)? [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? For documentation related changes: [ ] Have you ensured that format looks appropriate for the output in which it is rendered? Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/scottyaslan/nifi NIFI-3439 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1546.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1546 commit efade07d5ea39229073124bb8dd96b08387aabd7 Author: Scott Aslan <scottyaslan@gmail.com> Date: 2017-02-27T17:19:05Z NIFI-3439 when users type into sensitive property fields in NiFI, the values on the screen/browser should be masked *** unless specified by user to show plain text.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user mcgilman commented on the issue:

          https://github.com/apache/nifi/pull/1546

          Will review...

          Show
          githubbot ASF GitHub Bot added a comment - Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1546 Will review...
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user mcgilman commented on the issue:

          https://github.com/apache/nifi/pull/1546

          Hey @scottyaslan,

          This is a great start, but I think there are a few fundamental issues with how `PropertyDescriptors` relay what sort of editor should be used. There does not appear to be a cross-browser support for masking `textareas` (multi-line input). There exists sensitive properties that currently expect the field to support multi-line input. The `input[type=password]` only supports a single line.

          I think we would need to introduce a new attribute of `PropetyDescriptor` which would drive whether or not to use a masked single line input or the existing multi-line `textarea`. The existing multi-line `textareas` support sensitive by not returning/showing the value once set. We would not be able to support a `PropertyDescriptor` that requires masking and multi-line input.

          Additional complications exist for sensitive properties that support expression language. We'd have to spend some time to determine if `CodeMirror` supports masking or if it's possible to introduce that sort of capability. If not, we would not be able to support a `PropertyDescriptor` that requires masking and supports expression language.

          Show
          githubbot ASF GitHub Bot added a comment - Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1546 Hey @scottyaslan, This is a great start, but I think there are a few fundamental issues with how `PropertyDescriptors` relay what sort of editor should be used. There does not appear to be a cross-browser support for masking `textareas` (multi-line input). There exists sensitive properties that currently expect the field to support multi-line input. The `input [type=password] ` only supports a single line. I think we would need to introduce a new attribute of `PropetyDescriptor` which would drive whether or not to use a masked single line input or the existing multi-line `textarea`. The existing multi-line `textareas` support sensitive by not returning/showing the value once set. We would not be able to support a `PropertyDescriptor` that requires masking and multi-line input. Additional complications exist for sensitive properties that support expression language. We'd have to spend some time to determine if `CodeMirror` supports masking or if it's possible to introduce that sort of capability. If not, we would not be able to support a `PropertyDescriptor` that requires masking and supports expression language.

            People

            • Assignee:
              scottyaslan Scott Aslan
              Reporter:
              rvenkata Ramakrishnan V
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:

                Time Tracking

                Estimated:
                Original Estimate - 168h
                168h
                Remaining:
                Remaining Estimate - 168h
                168h
                Logged:
                Time Spent - Not Specified
                Not Specified

                  Development