Uploaded image for project: 'Apache NiFi'
  1. Apache NiFi
  2. NIFI-3369

Disable "Add" button on new connection dialog if no relationships selected

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.1.1
    • Fix Version/s: 1.4.0
    • Component/s: Core UI

      Description

      When adding a connection, if no relationships are selected, the "Add" button should be disabled. Otherwise, a user can click "Add" and then receive an error dialog that one or more relationships must be selected.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user yuri1969 opened a pull request:

          https://github.com/apache/nifi/pull/2152

          NIFI-3369 - Disable "Add" button on new connection dialog if no relationships selected

          Disabled confirmation button for both Create and Configure Connection
          dialogs when no relationship was selected.

          Thank you for submitting a contribution to Apache NiFi.

          In order to streamline the review of the contribution we ask you
          to ensure the following steps have been taken:

              1. For all changes:
          • [ ] Is there a JIRA ticket associated with this PR? Is it referenced
            in the commit message?
          • [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
          • [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
          • [x] Is your initial contribution a single, squashed commit?
              1. For code changes:
          • [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
          • [ ] Have you written or updated unit tests to verify your changes?
          • [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
          • [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
          • [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
          • [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
              1. For documentation related changes:
          • [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
              1. Note:
                Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/yuri1969/nifi NIFI-3369

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/nifi/pull/2152.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #2152


          commit cce5f28b3440a4a117390bf3cf5eff2fb5bc06d3
          Author: yuri1969 <1969yuri1969@gmail.com>
          Date: 2017-09-12T17:51:10Z

          NIFI-3369 - Disable "Add" button on new...

          ...connection dialog if no relationships selected

          Disabled confirmation button for both Create and Configure Connection
          dialogs when no relationship was selected.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user yuri1969 opened a pull request: https://github.com/apache/nifi/pull/2152 NIFI-3369 - Disable "Add" button on new connection dialog if no relationships selected Disabled confirmation button for both Create and Configure Connection dialogs when no relationship was selected. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: For all changes: [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. [x] Has your PR been rebased against the latest commit within the target branch (typically master)? [x] Is your initial contribution a single, squashed commit? For code changes: [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? [ ] Have you written or updated unit tests to verify your changes? [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0] ( http://www.apache.org/legal/resolved.html#category-a)? [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? For documentation related changes: [ ] Have you ensured that format looks appropriate for the output in which it is rendered? Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/yuri1969/nifi NIFI-3369 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2152.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2152 commit cce5f28b3440a4a117390bf3cf5eff2fb5bc06d3 Author: yuri1969 <1969yuri1969@gmail.com> Date: 2017-09-12T17:51:10Z NIFI-3369 - Disable "Add" button on new... ...connection dialog if no relationships selected Disabled confirmation button for both Create and Configure Connection dialogs when no relationship was selected.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user scottyaslan commented on the issue:

          https://github.com/apache/nifi/pull/2152

          Reviewing...

          Show
          githubbot ASF GitHub Bot added a comment - Github user scottyaslan commented on the issue: https://github.com/apache/nifi/pull/2152 Reviewing...
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 1f1269c817a32b32fd19f32f942dc92cbf1e4a8d in nifi's branch refs/heads/master from Yuri
          [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=1f1269c ]

          NIFI-3369 - Disable "Add" button on new...

          ...connection dialog if no relationships selected

          Disabled confirmation button for both Create and Configure Connection
          dialogs when no relationship was selected.

          Signed-off-by: Scott Aslan <scottyaslan@gmail.com>

          This closes #2152

          Show
          jira-bot ASF subversion and git services added a comment - Commit 1f1269c817a32b32fd19f32f942dc92cbf1e4a8d in nifi's branch refs/heads/master from Yuri [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=1f1269c ] NIFI-3369 - Disable "Add" button on new... ...connection dialog if no relationships selected Disabled confirmation button for both Create and Configure Connection dialogs when no relationship was selected. Signed-off-by: Scott Aslan <scottyaslan@gmail.com> This closes #2152
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/nifi/pull/2152

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/2152

            People

            • Assignee:
              Unassigned
              Reporter:
              alopresto Andy LoPresto
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development