[NIFI-3092] NiFi Toolkit bat files should quote command line args properly

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.0.0
• Fix Version/s: 1.1.0
• Assignee: Bryan Rosander
• Reporter: Bryan Rosander
• Created: 23/Nov/16 17:04
• Updated: 23/Nov/16 20:01
• Resolved: 23/Nov/16 20:01

Description

The toolkit bat files currently don't quote the command line arguments passed to them. This results in problems with spaces or special characters as arguments.

We should be able to address this by double-quoting the cmd arguments. If we add a space before the closing "", we should be able to handle whether or not the last argument is quoted.

E.g. without spaces -n "localhost(2)" would be rendered as -n "localhost(2)""" which breaks but with space it will be -n "localhost(2)" "" which is interpreted correctly.

See http://stackoverflow.com/questions/12891383/correct-quoting-for-cmd-exe-for-multiple-arguments#answer-12892791

Issue Links

• links to: GitHub Pull Request #1268