[NIFI-2474] TestRunner should not expose a VariableRegistry construct

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.0.0, 1.0.0-Beta
• Component/s: Tools and Build
• Assignee: Mark Payne
• Reporter: Mark Payne
• Created: 03/Aug/16 20:56
• Updated: 04/Aug/16 21:24
• Resolved: 04/Aug/16 15:25

Description

Currently, the TestRunners class provides a mechanism for creating a TestRunner that takes in a Variable Registry. The concept of providing variables to the Test Runner is very valuable. However, the notion of the VariableRegistry is an internal implementation detail that is getting exposed, creating a leaky abstraction.

We should remove the override of the createTestRunner() method that takes the Variable Registry and instead expose a set of methods of TestRunner:

void setVariable(String name, String value)
String getVariable(String name)
void setVariables(Map<String, String> variables)
Map<String, String> getVariables()

Additionally, as-is, if no VariableRegistry is provided, the default is to use a Variable Registry that provides System and Environment variables. This should be avoided, as it encourages unit tests to depend on environment-specific settings.

Issue Links

• links to: GitHub Pull Request #782