[NIFI-10630] Fixed Possible Json Ordering Permutations Problem in Tests

• Type: Test
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.18.0
• Fix Version/s: 1.19.0
• Component/s: NiFi Registry

Environment

Apache Maven 3.6.3
Java version: 11.0.16, vendor: Ubuntu, runtime: /usr/lib/jvm/java-11-openjdk-amd64
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "5.4.0-124-generic", arch: "amd64", family: "unix"

• Assignee: Unassigned
• Reporter: Boyu Li
• Created: 11/Oct/22 23:46
• Updated: 31/Oct/22 20:57
• Resolved: 31/Oct/22 20:57

Description

The test file

nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors
org.apache.nifi.processors.standard.TestWaitNotifyProtocol

has flakiness with the below three tests.

testNotifyAttributes
testNotifyCounters
testNotifyFirst

The test flakiness is due to comparisons between Json Strings and outputs from
cacheEntry.getValue() which is an Object AtomicCacheEntry<String, String, Long>

However, JsonObject does not guarantee entry orders, its object is an unordered set of name/value pairs, and internal permutations may occur in the output as JSON String.

 
Steps to reproduce the failure:
The flakiness was found with NonDex.
After installing NonDex and run the following code.

cd nifi
mvn install -pl nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors -am -DskipTests
mvn -pl nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors edu.illinois:nondex- 
  maven-plugin:1.1.3-SNAPSHOT:nondex - 
  Dtest=org.apache.nifi.processors.standard.TestWaitNotifyProtocol#testNotifyCounters 

 

 

Issue Links

• links to: GitHub Pull Request #6526