[NIFI-1044] fix inconsistency in how PropertyDescriptors that use StandardValidators.BOOLEAN_VALIDATOR are built

• Type: Improvement
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 0.3.0
• Component/s: Extensions
• Labels: inconsistency
• Assignee: Unassigned
• Reporter: Tony Kurc
• Created: 17/Oct/15 17:49
• Updated: 17/Oct/15 18:35

Description

There is some inconsistency in how Property descriptors are built when the validator is the BOOLEAN validator, notably with defaultValue and allowableValues

Sometimes this (Upper Case First Character)

                .defaultValue("True")
                .allowableValues("True", "False")
                .addValidator(StandardValidators.BOOLEAN_VALIDATOR)

Sometimes this (all lower case)

            .addValidator(StandardValidators.BOOLEAN_VALIDATOR)
            .allowableValues("true", "false")
            .defaultValue("true")

And sometimes no allowableValues are used.

Discovered when reviewing pull request for NIFI-944 and noticed the author of a pull request attempted to add allowableValues for consistency.