[NIFI-10303] GetElasticsearch processor invokes elasticsearch GET api without an identifier when flow file is null

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.16.3
• Fix Version/s: 1.19.0
• Labels: elasticsearch
• Assignee: Chris Sampson
• Reporter: Vijaya Gorla
• Created: 01/Aug/22 08:04
• Updated: 25/Oct/22 18:31
• Resolved: 25/Oct/22 18:31

Description

When GetElasticsearch processor has an incoming connection, and the document id is an expression, this results in expression evaluating to null when the processor runs without a flow file. This in turn results in elasticsearch GET api being invoked without an ID and elastic throwing an error.

Also noticed that other processors handle this scenario by short-circuiting at the beginning of onTrigger method

        FlowFile input = null;
        if (context.hasIncomingConnection()) {
            input = session.get();

            // If we have no FlowFile, and all incoming connections are self-loops then we can continue on.
            // However, if we have no FlowFile and we have connections coming from other Processors, then
            // we know that we should run only if we have a FlowFile.
            if (input == null && context.hasNonLoopConnection()) {
                return;
            }
        }

However GetElasticsearch does not.

Issue Links

• is related to: NIFI-10687 PutElasticsearchRecord/Json incorrectly try to use empty String as document _id
• links to: GitHub Pull Request #6573