Uploaded image for project: 'NetBeans'
  1. NetBeans
  2. NETBEANS-3898

ModuleList.doScanNetBeansOrgSources descends into .git/.hg

    XMLWordPrintableJSON

    Details

      Description

       org.netbeans.modules.apisupport.project.universe.ModuleList.doScanNetBeansOrgSources produces LOG entries like: 

      INFO...: exhaustive scan of F:\repos\netbeans\.hg\cache
      INFO...: exhaustive scan of F:\repos\netbeans\.hg\git
      ...

      Which come because of stuff after the following code, ("kids" is directories in <repo>/netebeans)

              for (File kid : kids) {
                  if (!kid.isDirectory()) {
                      continue;
                  }
                  String name = kid.getName();
                  if (EXCLUDED_DIR_NAMES.contains(name)) {
                      // #61579: known to not be project dirs, so skip to save time.
                      continue;
                  }
      

      Can save even more time by staying out of the repo data. Two possible solutions

      • Add ".git" and ".hg" to EXCLUDED_DIR_NAMES
      • Skip anything that starts with "."

      Comments? I'm inclined towards the second, skip anything that's hidden.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              errael Ernie Rael
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 1h
                1h