[NETBEANS-3518] fix bug in AbstractSummaryView.java

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 11.3
• Labels: pull-request-available
• Assignee: Brad Walker
• Reporter: Brad Walker
• Created: 02/Dec/19 20:48
• Updated: 03/Dec/19 23:19
• Resolved: 03/Dec/19 23:19

Description

I was working on my usual code cleanup when I encountered a bug in the method AbstractSummaryView() in AbstractSummaryView.java..

Notice the following code was not type-casting correctly..

-                if (selection.length == 1) {
-                    if (selection[0] instanceof ShowAllEventsItem) {
-                        showRemainingFiles(((ShowAllEventsItem) selection[0]).getParent(), true);
-                    } else if (selection[0] instanceof ShowLessEventsItem) {
-                        showRemainingFiles(((ShowAllEventsItem) selection[0]).getParent(), false);
-                    } else if (selection[0] instanceof MoreRevisionsItem) {

Specifically, an instance of ShowLessEventsItem should be properly cast..

+                        showRemainingFiles(((ShowLessEventsItem) selection.get(0)).getParent(), false);

While I had the hood opened, I fixed a few other Java warnings..

Issue Links

• links to: GitHub Pull Request #1722