[NETBEANS-3346] Upgrade asm-all jar to asm 7.2

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Implemented
• Affects Version/s: Next, 11.3
• Fix Version/s: 11.3
• Component/s: java - Platform
• Labels: pull-request-available

Environment

Fedora 31 & JDK Zulu 11.0.5

• Assignee: José Contreras
• Reporter: José Contreras
• Created: 06/Nov/19 00:34
• Updated: 03/Nov/20 15:47
• Resolved: 22/Nov/19 19:58

Description

I tried to upgrade the asm-all-5.0.1 library to the latest version 7.2 and received a nullPointerException (line 774 of asm-52 & asm-72 files). I already successfully upgrade it to version 5.1 (https://issues.apache.org/jira/browse/NETBEANS-3341).

After adding logging to the Asm.java file and try every release of the asm library (see https://asm.ow2.io/versions.html) and compare their source code I find the change that cause the nullPointerException:

 

https://gitlab.ow2.org/asm/asm/issues/317626

 

This change can be seen in the line 752 of the three files attached, this files are the starting up logs of the application.

My Asm.java fork:

 

https://github.com/pepness/incubator-netbeans/commit/c886770c0f90546020a24c93362357d3d351bcf5#diff-78005b879fd4d928c74ae21edf93ebafR360

 

Unfortunately I do not know nothing of Java bytecode manipulation nor the asm library to know what to do to upgrade this library.

 

My reason to update this library is for bug fixes, better support/code and better performance (https://asm.ow2.io/performance.html) .

Issue Links

• incorporates: NETBEANS-3341 Upgrade asm-all jar
• links to: GitHub Pull Request #1620