[NETBEANS-2437] Unit tests of php.editor fail

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 11.0
• Fix Version/s: Next
• Component/s: php - Editor
• Labels: pull-request-available
• Assignee: Junichi Yamamoto
• Reporter: Junichi Yamamoto
• Created: 20/Apr/19 10:45
• Updated: 03/Nov/20 15:44
• Resolved: 07/May/19 22:47

Description

Some unit tests fail.

Steps to reproduce

1. Open php.editor module
2. Right-click the module then click Run
3. Install Oracle JS Parser implementation
4. Stop the module
5. Open a unit test file: see the below
6. Right-click the editor
7. Click Run File or Test File

I've investigated a bit. It seems that unit tests fail after GraalJS Parser is removed.
commit: https://github.com/apache/incubator-netbeans/commit/3357fa5b18590908ac9de4ad7e55ab1fdf88cd50

e.g.

• https://github.com/apache/incubator-netbeans/blob/master/php/php.editor/test/unit/src/org/netbeans/modules/php/editor/actions/ImportDataCreatorTest.java
• https://github.com/apache/incubator-netbeans/blob/master/php/php.editor/test/unit/src/org/netbeans/modules/php/editor/indent/PHPFormatterHtmlTest.java

Unit tests passed when I've checkout https://github.com/apache/incubator-netbeans/commit/123f616488cbd335d63da493bb19b1aaabd0ac2f (previous commit)

Issue Links

• links to: GitHub Pull Request #1232