[NETBEANS-1836] Out of heap space removing large number of nodes

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Abandoned
• Affects Version/s: 8.2
• Component/s: platform - Explorer
• Labels: pull-request-available
• External issue URL: https://netbeans.org/bugzilla/show_bug.cgi?id=258435
• Assignee: Unassigned
• Reporter: Rangi Keen
• Created: 26/Dec/18 22:32
• Updated: 05/Feb/21 20:56
• Resolved: 02/Jan/21 22:44

Description

If you remove a large number of selected nodes (e.g. 10,000), you may run out of heap space. Note that this does not occur when deleting nodes because the nodes are first deselected, but it will happen if the nodes to be removed are not first deselected.

This seems to be related to bug #193852 designed to attempt to maintain cursor position when removing a node from the tree. Prior to the change for this bug, the node parent was set to null when the node was destroyed and therefore was not added to the list of nodes to be deselected in org.openide.explorer.view.TreeView.removedNodes.

One fix (in RemoveNodeOutOfHeapSpace.patch) is to change the check in org.openide.explorer.view.TreeView.removedNodes when adding to the removed selection list (remSel) to avoid adding paths for the nodes that will be deleted and only add the selected child nodes. This was put in place to avoid leaking memory for child nodes (see JDK-6472844), so I think this will maintain the intent and not result in further memory leaks.

Issue Links

• links to: GitHub Pull Request #1427