[NETBEANS-1481] Eager fragment with unsatisfied required token should't throw AssertionError

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 10.0
• Fix Version/s: Next
• Component/s: platform - Module System
• Labels: pull-request-available
• Assignee: Florian Vogler
• Reporter: Florian Vogler
• Created: 20/Oct/18 20:53
• Updated: 03/Nov/19 20:05
• Resolved: 24/Dec/18 08:29

Description

Due to changes related to NETBEANS-1147, the behaviour of loading module fragments has changed compared to netbeans 9.0.

Before the change eager fragments with unsatisfied token requirements remain disabled without any errors.

Expected behaviour:

• eager: fragment is loaded, if all  requirements  satisfied
• autoload: fragment is only loaded, if a module depends on it. If not all  requirements are satisfied, an error is shown.
• default:  fragment is loaded. If not all  requirements are satisfied, an error is shown.

Broken use case: 
Multiple eager OS specific fragments (Linux, MacOS, Windows) not working any more.

Issue Links

• relates to: NETBEANS-1147 Enabling fragment has to enable host bundle first
• links to: GitHub Pull Request #976
• links to: GitHub Pull Request #978