[NET-656] FTPSClient#execPROT appears to call initSslContext too late

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Component/s: FTP
• Assignee: Unassigned
• Reporter: Sebb
• Created: 08/Feb/18 14:06
• Updated: 08/Feb/18 14:06

Description

FTPSClient#execPROT calls initSslContext after the context field has been used to create a couple of socket factories. However initSslContext is what sets up initSslContext if necessary.

Either the call needs to be moved to before the context field is first used, or it needs to be dropped as it's not necessary. It looks like it is not necessary, as the socket factory methods would fail with NPE if the factories had been created with a null config.