[NET-525] Added missing set methods on NTP class and interface

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.3
• Fix Version/s: 3.4
• Labels: ntp
• Assignee: Unassigned
• Reporter: jason mathews
• Created: 19/Feb/14 20:35
• Updated: 26/Nov/15 16:34
• Resolved: 20/Feb/14 18:58

Description

I was the original contributor of the NTP implementation and have recently cleaned the source and submitting the relevant changes.

Here is the summary of changes:

src/main/java/org/apache/commons/net/ntp/TimeInfo.java
-Added missing equals() and hashCode() methods
-Added new method: getAddress()

src/main/java/org/apache/commons/net/ntp/NtpV3Packet.java
-Added missing methods: setPrecision(), setRootDelay(), and setRootDispersion()

src/main/java/org/apache/commons/net/ntp/NtpV3Impl.java
-Added missing equals() and hashCode() methods
-Added missing set methods: setRootDelay(), setRootDispersion(),
-Added validation check to setDatagramPacket()

Added additional tests:
-src/test/java/org/apache/commons/net/ntp/TestNtpPacket.java
-src/test/java/org/apache/commons/net/ntp/TestTimeInfo.java

See attached patch.