Uploaded image for project: 'Commons Net'
  1. Commons Net
  2. NET-525

Added missing set methods on NTP class and interface

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.3
    • Fix Version/s: 3.4
    • Component/s: None
    • Labels:

      Description

      I was the original contributor of the NTP implementation and have recently cleaned the source and submitting the relevant changes.

      Here is the summary of changes:

      src/main/java/org/apache/commons/net/ntp/TimeInfo.java
      -Added missing equals() and hashCode() methods
      -Added new method: getAddress()

      src/main/java/org/apache/commons/net/ntp/NtpV3Packet.java
      -Added missing methods: setPrecision(), setRootDelay(), and setRootDispersion()

      src/main/java/org/apache/commons/net/ntp/NtpV3Impl.java
      -Added missing equals() and hashCode() methods
      -Added missing set methods: setRootDelay(), setRootDispersion(),
      -Added validation check to setDatagramPacket()

      Added additional tests:
      -src/test/java/org/apache/commons/net/ntp/TestNtpPacket.java
      -src/test/java/org/apache/commons/net/ntp/TestTimeInfo.java

      See attached patch.

        Attachments

        1. diff.patch.txt
          22 kB
          jason mathews

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              docjason jason mathews
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: