[NET-396] POP3.setState() should not be public

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Not A Problem
• Affects Version/s: 2.2
• Component/s: POP3
• Assignee: Unassigned
• Reporter: Sebb
• Created: 29/Mar/11 01:47
• Updated: 12/Apr/11 19:01
• Resolved: 12/Apr/11 19:01

Description

The POP3 method setState() is public. However, the state should only be settable by library methods, not by client code, otherwise the state checks won't work correctly.

Changing the visibility would break binary compatibility.

To maintain compatibility there could be a new method (package-private, which would give test cases access) which is allowed to set the state. Also change the public method to either do nothing or throw an UnsupportedOperationException.

The getState() method can remain public.