Commons Net
  1. Commons Net
  2. NET-384

KeyManagerUtils - the KeyManager is not efficient

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0
    • Component/s: None
    • Labels:
      None

      Description

      The clientKey manager performs some of the work that could be done as part of creating the key store.

      Since the manager is potentially called many times, it would be better to move the setup processing to the creation of the keystore.

      This requires creating a sub-class of KeyStore, which might as well be a private class created by createClientKeyManager()

      The calling sequence would then be:

      KeyManager km = KeyManagerUtils.createClientKeyManager(
          "JKS", "/path/to/privatekeystore.jks", "storepassword", "privatekeyalias", "keypassword");
      FTPSClient cl = new FTPSClient();
      cl.setKeyManager(km);
      

      For JKS stores with a single entry and keypassword == storepassword this would simplify to:

      KeyManager km = KeyManagerUtils.createClientKeyManager("/path/to/privatekeystore.jks", "storepassword");
      FTPSClient cl = new FTPSClient();
      cl.setKeyManager(km);
      

        Activity

        Sebb created issue -
        Sebb made changes -
        Field Original Value New Value
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Sebb made changes -
        Fix Version/s 3.0 [ 12314126 ]
        Sebb made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        2h 47m 1 Sebb 21/Mar/11 17:43
        Resolved Resolved Closed Closed
        75d 1h 42m 1 Sebb 04/Jun/11 20:26

          People

          • Assignee:
            Unassigned
            Reporter:
            Sebb
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development