Uploaded image for project: 'Commons Net'
  1. Commons Net
  2. NET-278

FTPClient.disconnect() shouldn't throw IOException

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Later
    • 2.0
    • 3.0
    • None
    • None
    • All

    Description

      FTPClient.disconnect() shouldn't throw IOExceptions because it is typically placed in a finally block and it doesn't make much sense to
      try {
      client.disconnect()
      } catch (IOException e) {
      // You can't actually do anything
      }
      What is the purpose of such an exception if nobody can use it? There's nothing we can do if the client couldn't disconnect... You always usa a catch block with a /do nothing/ in your samples, so I think it's only an elegant thing to have a try block in a finally block...

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              raffaele181188 Raffaele Sgarro
              Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - 5m
                  5m
                  Remaining:
                  Remaining Estimate - 5m
                  5m
                  Logged:
                  Time Spent - Not Specified
                  Not Specified