Uploaded image for project: 'Commons Net'
  1. Commons Net
  2. NET-164

WhoisClient should not use the platform's default Encoding

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0
    • Component/s: None
    • Labels:
      None

      Description

      Currently the WhoisClient is extending the FingerClient, which sends its request like so:

      output = new DataOutputStream(new BufferedOutputStream(output, 1024));
      output.writeBytes(__query.toString());

      This obviously uses the platform's default encoding, which may be workable for Finger requests, but today's Whois services oftentimes support foreign characters via some IDN scheme and therefore usually run under utf-8. It should therefore either be configurable which encoding is used for the request, or, alternatively, the query interface should be changed to not accept strings, but only bytes. Then it's the client's responsibility to do the appropriate thing.

      As it is now, there is no way to use this WhoisClient for IDN-aware Whois registries.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              ulim@denic.de Ulrich Mayring
            • Votes:
              1 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: