[NEMO-238] Optimize processElement in TaskExecutor

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.1
• Assignee: Unassigned
• Reporter: Tae-Geon Um
• Created: 26/Oct/18 04:55
• Updated: 25/Nov/18 23:30
• Resolved: 29/Oct/18 01:29

Description

TaskExecutor checks every source element and branches them according to the type of the first IR vertex.

private void processElement(final VertexHarness vertexHarness, final Object dataElement) {
    final IRVertex irVertex = vertexHarness.getIRVertex();
    final OutputCollector outputCollector = vertexHarness.getOutputCollector();
    // TODO #XXX: optimize processElement (do not check instanceof for each data element)
    if (irVertex instanceof SourceVertex) {
      outputCollector.emit(dataElement);
    } else if (irVertex instanceof OperatorVertex) {
      final Transform transform = ((OperatorVertex) irVertex).getTransform();
      transform.onData(dataElement);
    } else {
      throw new UnsupportedOperationException("This type of IRVertex is not supported");
    }
  }

We can remove this checking because the IRvertex is determined statically and does not change.

Issue Links

• is caused by: NEMO-235 Refactor TaskExecutor's data processing logic