[MYFACES-990] Unhelpful stack trace when tag value binding returns wrong type.

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Won't Fix
• Affects Version/s: 1.1.1
• Component/s: General
• Assignee: Martin Marinschek
• Reporter: Steve Peterson
• Created: 31/Dec/05 05:47
• Updated: 28/Aug/15 16:25
• Resolved: 28/Aug/15 16:25

Description

In the implementation of each UIComponent, the canonical logic for retrieving a non-String property is to cast the result
of the valueBinding.getValue() method to the expected type.

public boolean isItemDisabled()

{ if (_itemDisabled != null) return _itemDisabled.booleanValue(); ValueBinding vb = getValueBinding("itemDisabled"); Boolean v = vb != null ? (Boolean)vb.getValue(getFacesContext()) : null; return v != null ? v.booleanValue() : DEFAULT_ITEMDISABLED; }

Yields an obscure stack trace that doesn't yield the ID of the component or the property that is being referenced:

ERROR 14:45:28 [[jsp]] Servlet.service() for servlet jsp threw exception
java.lang.ClassCastException: java.lang.String
at javax.faces.component.html.HtmlInputText.isDisabled(HtmlInputText.java:117)
at org.apache.myfaces.renderkit.html.HtmlTextRendererBase.isDisabled(HtmlTextRendererBase.java:157)
at org.apache.myfaces.renderkit.html.ext.HtmlTextRenderer.isDisabled(HtmlTextRenderer.java:45)
at org.apache.myfaces.renderkit.html.HtmlTextRendererBase.renderInput(HtmlTextRendererBase.java:144)
at org.apache.myfaces.renderkit.html.HtmlTextRendererBase.encodeEnd(HtmlTextRendererBase.java:50)
at org.apache.myfaces.renderkit.html.ext.HtmlTextRenderer.renderNormal(HtmlTextRenderer.java:72)
at org.apache.myfaces.renderkit.html.ext.HtmlTextRenderer.encodeEnd(HtmlTextRenderer.java:58)