MyFaces Core
  1. MyFaces Core
  2. MYFACES-654

HTML TLD differences between myFaces and the RI

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.1.0, 1.1.1, 1.1.2, 1.1.3, 1.1.4, 1.1.4.1-SNAPSHOT, 1.1.5-SNAPSHOT
    • Fix Version/s: None
    • Component/s: General
    • Labels:
      None

      Description

      There are still differences in the possible attributes between myFaces and the RI.

      myFaces attributes not in the RI:

      commandButton
      size

      commandLink
      onclick

      dataTable
      align
      datafld
      dataformatas
      datasrc

      form
      name

      inputSecret
      align

      inputText
      align

      inputTextarea
      datafld
      dataformatas
      datasrc

      message
      dir
      lang
      onclick
      ondblclick
      onkeydown
      onkeypress
      onkeyup
      onmousedown
      onmousemove
      onmouseout
      onmouseover
      onmouseup

      messages
      dir
      lang
      onclick
      ondblclick
      onkeydown
      onkeypress
      onkeyup
      onmousedown
      onmousemove
      onmouseout
      onmouseover
      onmouseup

      outputFormat
      dir
      lang
      onclick
      ondblclick
      onkeydown
      onkeypress
      onkeyup
      onmousedown
      onmousemove
      onmouseout
      onmouseover
      onmouseup

      outputText
      dir
      lang
      onclick
      ondblclick
      onkeydown
      onkeypress
      onkeyup
      onmousedown
      onmousemove
      onmouseout
      onmouseover
      onmouseup

      panelGrid
      align
      datafld
      dataformatas
      datasrc

      panelGroup
      dir
      lang
      onclick
      ondblclick
      onkeydown
      onkeypress
      onkeyup
      onmousedown
      onmousemove
      onmouseout
      onmouseover
      onmouseup
      title

      selectBooleanCheckbox
      alt
      datafld
      dataformatas
      datasrc

      selectManyCheckbox
      alt
      datafld
      dataformatas
      datasrc

      selectManyListbox
      datafld
      dataformatas
      datasrc

      selectManyMenu
      datafld
      dataformatas
      datasrc

      selectOneListbox
      datafld
      dataformatas
      datasrc

      selectOneMenu
      datafld
      dataformatas
      datasrc

      selectOneRadio
      alt
      datafld
      dataformatas
      datasrc

      --------------------------------------------------------------

      Attributes missing in myFaces:

      commandButton
      readonly

      outputLabel
      tabindex

      selectManyCheckbox
      border

      selectManyListbox
      accesskey
      onselect

      selectManyMenu
      accesskey
      onselect

      selectOneListbox
      accesskey
      onselect

      selectOneMenu
      accesskey
      onselect

      --------------------------------------------------------------

      Case difference:

      form
      acceptCharset <-> acceptcharset

        Activity

        Hide
        Martin Marinschek added a comment -

        Wow.

        Can I take this for granted, or do I need to double check?

        regards,

        Martin

        Show
        Martin Marinschek added a comment - Wow. Can I take this for granted, or do I need to double check? regards, Martin
        Hide
        Manfred Klug added a comment -

        I have checked the list twice, but who is perfect?

        Show
        Manfred Klug added a comment - I have checked the list twice, but who is perfect?
        Hide
        Grant Smith added a comment -

        Martin,

        I have resolved <h:form name> in another JIRA. Would you like me to take over work on this ?

        Show
        Grant Smith added a comment - Martin, I have resolved <h:form name> in another JIRA. Would you like me to take over work on this ?
        Hide
        Martin Marinschek added a comment -

        If you can - yes thanks a bunch. I am assigning over to you.

        regards,

        Martin

        Show
        Martin Marinschek added a comment - If you can - yes thanks a bunch. I am assigning over to you. regards, Martin
        Hide
        Benjamin Hawkes-Lewis added a comment -

        Hello.

        I'm confused about the status of the name attribute on form elements issue.

        Reading JIRA MYFACES-798 and Grant Smith's 8 November comment above implies that it has been resolved. But the "current" org.apache.myfaces.shared.renderkit.html.HtmlFormRendererBase still contains the line which (I assume) causes the "name" attribute to be added to the "form" element (line 63: " writer.writeAttribute(HTML.NAME_ATTR, clientId, null);"). As far as I can tell, this revision 395926 is the latest version in the Subversion repository, so this issue looks suspiciously like it is still live.

        I've probably just misunderstood something (I'm only a newbie to all this stuff), but as I'm looking for a good way of generating XHTML strict interfaces for a Java web application I thought I ought to chase it up.

        Name attributes on form elements only scraped into HTML 4.01 "for backwards compatibility" reasons (see http://www.w3.org/TR/html4/interact/forms.html#h-17.3), and are invalid with an XHTML strict DTD.

        Regards,

        Benjamin Hawkes-Lewis

        Show
        Benjamin Hawkes-Lewis added a comment - Hello. I'm confused about the status of the name attribute on form elements issue. Reading JIRA MYFACES-798 and Grant Smith's 8 November comment above implies that it has been resolved. But the "current" org.apache.myfaces.shared.renderkit.html.HtmlFormRendererBase still contains the line which (I assume) causes the "name" attribute to be added to the "form" element (line 63: " writer.writeAttribute(HTML.NAME_ATTR, clientId, null);"). As far as I can tell, this revision 395926 is the latest version in the Subversion repository, so this issue looks suspiciously like it is still live. I've probably just misunderstood something (I'm only a newbie to all this stuff), but as I'm looking for a good way of generating XHTML strict interfaces for a Java web application I thought I ought to chase it up. Name attributes on form elements only scraped into HTML 4.01 "for backwards compatibility" reasons (see http://www.w3.org/TR/html4/interact/forms.html#h-17.3 ), and are invalid with an XHTML strict DTD. Regards, Benjamin Hawkes-Lewis
        Hide
        Grant Smith added a comment -

        Benjamin is correct. I have removed the name from the TLD taglibrary, but it seems Myfaces puts in a default name anyway. I have time once again to look into this, at long last.. My apologies for this dragging out this long.

        Show
        Grant Smith added a comment - Benjamin is correct. I have removed the name from the TLD taglibrary, but it seems Myfaces puts in a default name anyway. I have time once again to look into this, at long last.. My apologies for this dragging out this long.
        Hide
        Steve Wells added a comment -

        I'm anxious to see accesskey for the listboxes + others - any idea on when those will be included (was hoping 1.1.4 but it appears that taglib shows the same deficiencies). Thanks.

        Show
        Steve Wells added a comment - I'm anxious to see accesskey for the listboxes + others - any idea on when those will be included (was hoping 1.1.4 but it appears that taglib shows the same deficiencies). Thanks.
        Hide
        Paul Spencer added a comment -

        Selenium tests have been added/update to verify the attributes described in "Attributes missing in myFaces: " The Selenium tests run successfully using Sun's RI against a FireFox browser.

        Show
        Paul Spencer added a comment - Selenium tests have been added/update to verify the attributes described in "Attributes missing in myFaces: " The Selenium tests run successfully using Sun's RI against a FireFox browser.
        Hide
        Grant Smith added a comment -

        Hmm.. now that it's time to remove the attributes in Myfaces that are not present in the RI, I'm worried about breaking user's applications that may already depend on them ? For example, I cam see how people would use the onclick attribute of commandLink, and be frustrated that it no longer works after it's removed. What's the general feeling on this, should we go ahead and remove all these attributres, or just leave them in ?

        P.S. I just removed the commandButton's size attribute

        Show
        Grant Smith added a comment - Hmm.. now that it's time to remove the attributes in Myfaces that are not present in the RI, I'm worried about breaking user's applications that may already depend on them ? For example, I cam see how people would use the onclick attribute of commandLink, and be frustrated that it no longer works after it's removed. What's the general feeling on this, should we go ahead and remove all these attributres, or just leave them in ? P.S. I just removed the commandButton's size attribute
        Hide
        Grant Smith added a comment -

        This should no longer be an issue due to the new builder-plugin's automatic generation of tags, etc.

        Show
        Grant Smith added a comment - This should no longer be an issue due to the new builder-plugin's automatic generation of tags, etc.

          People

          • Assignee:
            Grant Smith
            Reporter:
            Manfred Klug
          • Votes:
            8 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development