Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.1.5
    • Component/s: General
    • Labels:
      None

      Description

      MyFaces could be improved by checking the code using findbugs (findbugs.sourceforge.net/ ).
      See also: findbugs.sourceforge.net/docs/findbugsPaper.pdf

      1. findbugs-all.diff
        2 kB
        Stephan Strittmatter
      2. findbugs-api.diff
        2 kB
        Stephan Strittmatter
      3. findbugs-impl.diff
        2 kB
        Stephan Strittmatter
      4. findbugs-sandbox.diff
        2 kB
        Stephan Strittmatter
      5. findbugs-tomahawk.diff
        2 kB
        Stephan Strittmatter

        Activity

        Hide
        Bernd Bohmann added a comment -

        Added the findbug pluginn to the master-pom.
        Should be included in current build of trunk.

        Show
        Bernd Bohmann added a comment - Added the findbug pluginn to the master-pom. Should be included in current build of trunk.
        Hide
        Matthias Weßendorf added a comment -
        Show
        Matthias Weßendorf added a comment - looks like out of sbox http://mojo.codehaus.org/findbugs-maven-plugin/
        Hide
        Matthias Weßendorf added a comment -

        any news, bernd ?

        Show
        Matthias Weßendorf added a comment - any news, bernd ?
        Hide
        Bernd Bohmann added a comment -

        The findbugs-maven-plugin is in the mojo sandbox.

        We should wait until the plugin is released on a public repository.

        Show
        Bernd Bohmann added a comment - The findbugs-maven-plugin is in the mojo sandbox. We should wait until the plugin is released on a public repository.
        Hide
        Stephan Strittmatter added a comment -

        Okay I am not very familar with the MyFaces project at all. I will check this and try to create a new patch then in respect of information at http://myfaces.apache.org/buildhowto.html.

        Show
        Stephan Strittmatter added a comment - Okay I am not very familar with the MyFaces project at all. I will check this and try to create a new patch then in respect of information at http://myfaces.apache.org/buildhowto.html .
        Hide
        Grant Smith added a comment -

        Stephan,

        I agree that this would be very useful. However, the way the build.xml files work on this project, they are all in fact svn:externals of the same file. See the "one buildfile to rule them all" discussion in the archives. Basically you have to create a patch that only patches the main buildfile.

        Show
        Grant Smith added a comment - Stephan, I agree that this would be very useful. However, the way the build.xml files work on this project, they are all in fact svn:externals of the same file. See the "one buildfile to rule them all" discussion in the archives. Basically you have to create a patch that only patches the main buildfile.
        Hide
        Stephan Strittmatter added a comment -

        Sorry, I was not able to create one diff-file, so I added for every build.xml an own diff.

        Show
        Stephan Strittmatter added a comment - Sorry, I was not able to create one diff-file, so I added for every build.xml an own diff.
        Hide
        Stephan Strittmatter added a comment -

        patch to add findbugs-task to build.xml of tomahawk build.

        Show
        Stephan Strittmatter added a comment - patch to add findbugs-task to build.xml of tomahawk build.
        Hide
        Stephan Strittmatter added a comment -

        patch to add findbugs-task to build.xml of sandbox build.

        Show
        Stephan Strittmatter added a comment - patch to add findbugs-task to build.xml of sandbox build.
        Hide
        Stephan Strittmatter added a comment -

        patch to add findbugs-task to build.xml of impl build.

        Show
        Stephan Strittmatter added a comment - patch to add findbugs-task to build.xml of impl build.
        Hide
        Stephan Strittmatter added a comment -

        patch to add findbugs-task to build.xml of api build.

        Show
        Stephan Strittmatter added a comment - patch to add findbugs-task to build.xml of api build.
        Hide
        Stephan Strittmatter added a comment -

        patch to add findbugs-task to build.xml of general build.

        Show
        Stephan Strittmatter added a comment - patch to add findbugs-task to build.xml of general build.

          People

          • Assignee:
            Bernd Bohmann
            Reporter:
            Stephan Strittmatter
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development