MyFaces Core
  1. MyFaces Core
  2. MYFACES-476

commandButton doesn't renders well the application-dependent image urls

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.1.1
    • Fix Version/s: 1.1.2
    • Component/s: General
    • Labels:
      None
    • Environment:
      Version 2005.08.28

      Description

      Whenever the graphicImage component renders it's url attribute by passing it through the viewhandler (see org.apache.myfaces.renderkit.html.HtmlImageRendererBase.java: line 66-70), and encoded as an application-dependent url if required; if I set the image attribute for a commandButton component, it's image attribute rendered as it is (see org.apache.myfaces.renderkit.html.HtmlButtonRendererBase.java: line 91).

        Issue Links

          Activity

          Hide
          Mathias Broekelmann added a comment -

          the application context path should be prefixed to the path given by the image attribute.
          I could not find a note about this in the spec. So I agree changing this. Although that would break existing apps if they used a workaround for that.

          Any other opinions?

          Show
          Mathias Broekelmann added a comment - the application context path should be prefixed to the path given by the image attribute. I could not find a note about this in the spec. So I agree changing this. Although that would break existing apps if they used a workaround for that. Any other opinions?
          Hide
          Mathias Broekelmann added a comment -

          change to impl since h:commandbutton is affected

          Show
          Mathias Broekelmann added a comment - change to impl since h:commandbutton is affected
          Hide
          Martin Marinschek added a comment -

          I'd say go ahead and change it

          regards,

          Martin

          Show
          Martin Marinschek added a comment - I'd say go ahead and change it regards, Martin
          Hide
          Mathias Broekelmann added a comment -

          fixed in trunk and 1.1.1 branch

          Show
          Mathias Broekelmann added a comment - fixed in trunk and 1.1.1 branch

            People

            • Assignee:
              Mathias Broekelmann
              Reporter:
              Csaba Sebastian
            • Votes:
              1 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development