[MYFACES-4596] faces.ts style tags must retain their original position (and script tags as well)

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 4.0.0
• Fix Version/s: 4.0.1
• Assignee: Werner Punz
• Reporter: Werner Punz
• Created: 21/Mar/23 13:41
• Updated: 12/Jun/23 12:59
• Resolved: 27/Mar/23 15:16

Description

This bug came from a corner case the Tobago guys had.

The problem is that the style tags are not retained at their proper position, but are evaled like script tags via the head appendix method.

While script tags only can be evaluated by appending them on the head for a short period of time, this is not needed for style tags.

I have a solution for this (see https://github.com/werpu/jsfs_js_ts/pull/35 in the comments)

The Tobago guys thankfully have provided a test case. 

Fix will be in 4.0.1 including the provided unit test!

 

Note: I consider this a minor, bug, because it does not prevent the style tags to be properly evaluated by the browser, just if code needs to check for embedded style tags being in their proper location, this becomes a major issue! This very likely only affects component libraries (I have yet to have had this case in a project, hence I did not have it on the radar)

Nevertheless it will be fixed!

 

Issue Links

• links to: GitHub Pull Request #557