[MYFACES-4475] TCK: Spec1568IT: test failure do to an exta space in DOCTYPE - ASF JIRA

XML

Word

Printable

JSON

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 4.0.0-RC1, 2.2.15, 2.3.10, 2.3-next-M7, 3.0.2
Fix Version/s: 2.3.11, 3.0.3, 2.3-next-M8, 2.2.16, 4.0.0-RC2
Component/s: General
Labels:
None

Description

The following test fails with MyFaces: https://github.com/jakartaee/faces/blob/master/tck/faces40/doctype/src/test/java/ee/jakarta/tck/faces/test/servlet50/doctype/Spec1568IT.java

org.junit.ComparisonFailure: Page is using HTML5 doctype expected:<<!DOCTYPE html[]>> but was:<<!DOCTYPE html[ ]>>
org.junit.ComparisonFailure: Page is using XHTML4 transitional public doctype expected:<...l1-transitional.dtd"[]>> but was:<...l1-transitional.dtd"[ ]>>
org.junit.ComparisonFailure: Page is using XHTML4 strict system doctype expected:<...D/xhtml1-strict.dtd"[]>> but was:<...D/xhtml1-strict.dtd"[ ]>>

There is an extra space before the closing of DOCTYPE:
<!DOCTYPE HTML > vs <!DOCTYPE HTML>

This is due to the following line of code: https://github.com/apache/myfaces/blob/main/impl/src/main/java/org/apache/myfaces/view/facelets/compiler/DoctypeInstruction.java#L68