[MYFACES-4107] StringIndexOutOfBoundsException in getResourceVersion

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0.24, 2.1.18, 2.2.12, 2.3.0
• Fix Version/s: 2.3.0-beta
• Environment: WebSphere Liberty
• Assignee: Bill Lucy
• Reporter: Bill Lucy
• Created: 05/Apr/17 16:19
• Updated: 09/Jun/17 01:24
• Resolved: 07/Apr/17 18:43

Description

I've run into a case where, given an incorrect context parameter, a StringIndexOutOfBoundsException is thrown. This occurs in WebSphere Liberty because the server normalizes the external context resource paths during app initialization.

For example, this parameter:

<context-param>
<param-name>javax.faces.WEBAPP_RESOURCES_DIRECTORY</param-name>
<param-value>/META-INF/resources</param-value>
</context-param>

throws:

java.lang.StringIndexOutOfBoundsException: String index out of range: 35
at java.lang.String.substring(String.java:1377)
at org.apache.myfaces.shared.resource.ExternalContextResourceLoader.getResourceVersion(ExternalContextResourceLoader.java:81)

That parameter value is not allowed to have a leading slash. However, the current exception is not very helpful, and can be easily avoided.

I'll attach a patch which avoids the StringIndexOutOfBoundsException in getResourceVersion(); we already have this logic in getLibraryVersion().