[MYFACES-3748] Bug in check for required attribute at Composite Components

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.1.12
• Fix Version/s: 2.0.19, 2.1.13
• Assignee: Leonardo Uribe
• Reporter: dennis hoersch
• Created: 12/Aug/13 09:45
• Updated: 22/Oct/13 15:59
• Resolved: 14/Sep/13 23:29

Description

The check for required attributes at Composite Components in CompositeComponentResourceTagHandler does not parses literal booleans right. It uses Boolean.getBoolen(systemProperty) which looks up a System property with the given name. Boolean.valueOf(string) should be used instead:

CompositeComponentResourceTagHandler.createComponent(FaceletContext)

Object value = ve.getValue(facesContext.getELContext());
Boolean required = null;
if (value instanceof Boolean)

{ required = (Boolean) value; }

else if (value != null)

{ required = Boolean.valueOf(value.toString()); }

if (required != null && required.booleanValue())
{
Object attrValue = this.tag.getAttributes().get (propertyDescriptor.getName());

if (attrValue == null)

{ throw new TagException(this.tag, "Attribute '" + propertyDescriptor.getName() + "' is required"); }

}