[MYFACES-3721] Override of uniqueIdCounter for UIViewRoot in restoreView cause component duplicate id exception

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.0.18, 2.1.12
• Component/s: JSR-314
• Assignee: Leonardo Uribe
• Reporter: Leonardo Uribe
• Created: 12/May/13 17:56
• Updated: 29/May/13 18:25
• Resolved: 12/May/13 17:59

Description

I have found an issue with the solution applied in MYFACES-3663. The steps to cause the problem are the following:

1. The view is rendered and some unique ids are generated. UIViewRoot has state and it is saved.
2. The view needs to be restored, PSS algorithm takes the uniqueIdCounter from the state and set it to UIViewRoot, then the initial state is constructed using facelets algorithm
3. Inside facelets algorithm, a new component is created and that increase uniqueIdCounter (f:ajax tag handler adds default jsf.js and ask for a unique id from UIViewRoot).
4. The delta state is applied, overriding uniqueIdCounter.
5. A new component is created in render response phase, creating the duplicate id condition.
6. The state saving algorithm detects the duplicate id and throw duplicate id exception.

The conditions required to reproduce the problem are very unlikely, so other tests done were not able to reproduce the problem.

Issue Links

• is related to: MYFACES-3663 UIViewRoot.createUniqueId() should generate unique ids for all the component tree.