MyFaces Core
  1. MyFaces Core
  2. MYFACES-3671

jsf-uncompressed.js contains 'import' of not existing file '_FinalizeableObj.js'

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.1.10
    • Fix Version/s: 2.2.0-beta
    • Component/s: None
    • Labels:
      None
    • Environment:
      Firefox

      Description

      The 'jsf-uncompressed.js' tries to load the script '_FinalizeableObj.js' that seams not to exist?

      _ls("#

      {resource['org.apache.myfaces.core.impl.xhrCore:_FinalizeableObj.js']}

      ", null, null, "UTF-8", false);

      This results in an empty string for the load:

      _ls("", null, null, "UTF-8", false);

      which causes a second request to the original page in my browser.

        Activity

        Hide
        Werner Punz added a comment -

        This is indeed a refactoring bug, the FinalizableObject was renamed to Object under the myfaces namespace.
        I will fix this asap.

        Show
        Werner Punz added a comment - This is indeed a refactoring bug, the FinalizableObject was renamed to Object under the myfaces namespace. I will fix this asap.
        Hide
        dennis hoersch added a comment -

        Thank you.

        Maybe it is a good idea to prevent cases like this (see also https://issues.apache.org/jira/browse/MYFACES-3519) if there is a check in the loadScript method? Like the following

        this.loadScript = function(src, type, defer, charSet, async) {
        if (!src )

        { throw Error("Script to load must not be an empty string!"); }

        // the chrome engine has a nasty javascript bug which prevents
        // a correct order of scripts being loaded
        // if you use script source on the head, we have to revert
        // to xhr+ globalEval for those
        var b = _T.browser;
        if (!b.isFF && !b.isWebkit && !b.isOpera >= 10)

        { _T.loadScriptEval(src, type, defer, charSet); }

        else

        { // only firefox keeps the order, sorry ie... _T.loadScriptByBrowser(src, type, defer, charSet, async); }

        };

        Show
        dennis hoersch added a comment - Thank you. Maybe it is a good idea to prevent cases like this (see also https://issues.apache.org/jira/browse/MYFACES-3519 ) if there is a check in the loadScript method? Like the following this.loadScript = function(src, type, defer, charSet, async) { if (!src ) { throw Error("Script to load must not be an empty string!"); } // the chrome engine has a nasty javascript bug which prevents // a correct order of scripts being loaded // if you use script source on the head, we have to revert // to xhr+ globalEval for those var b = _T.browser; if (!b.isFF && !b.isWebkit && !b.isOpera >= 10) { _T.loadScriptEval(src, type, defer, charSet); } else { // only firefox keeps the order, sorry ie... _T.loadScriptByBrowser(src, type, defer, charSet, async); } };

          People

          • Assignee:
            Werner Punz
            Reporter:
            dennis hoersch
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development