[MYFACES-3630] PartialViewContextImpl.findHeadComponent and findBodyComponent does not take into account h:head or h:body inside child of UIViewRoot

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.0.16, 2.1.10
• Assignee: Leonardo Uribe
• Reporter: Leonardo Uribe
• Created: 18/Oct/12 19:45
• Updated: 20/Nov/12 23:44
• Resolved: 18/Oct/12 19:46

Description

There is a small bug on PartialViewContextImpl.findHeadComponent. It says this:

private UIComponent findHeadComponent(UIViewRoot root)
{
for (UIComponent child : root.getChildren())
{
if (child instanceof HtmlHead)

{ return child; }
else
{
for (UIComponent grandchild : child.getChildren())
{
if (child instanceof HtmlHead)
{ return child; }
}
}
}
return null;
}

but it should be this:

private UIComponent findHeadComponent(UIViewRoot root)
{
for (UIComponent child : root.getChildren())
{
if (child instanceof HtmlHead)
{ return child; }

else
{
for (UIComponent grandchild : child.getChildren())
{
if (grandchild instanceof HtmlHead)

{ return grandchild; }

}
}
}
return null;
}

Usually h:head and h:body are direct children of UIViewRoot, so it is difficult to see any problem. This is only relevant when org.apache.myfaces.STRICT_JSF_2_REFRESH_TARGET_AJAX web config param is set to true.