[MYFACES-350] Use 'node.isLeaf()' in tree2 to decide whether to display the navigation icon

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.1.0
• Fix Version/s: 1.1.0
• Environment: IBM RAS using MyFaces JSF implementation
• Assignee: Unassigned
• Reporter: Brendan Conner
• Created: 22/Jul/05 00:55
• Updated: 17/Apr/06 20:50
• Resolved: 26/Jul/05 05:45

Description

I would like to suggest the following enhancement to Tree2 that would make it more amenable to grabbing data "on the fly" as the user is expanding nodes. Here's the problem:

Currently, Tree2 does not display the + navigation icon if the number of child nodes is zero, regardless of whether there are children yet to be fetched. What I'd like to have happen is that the + navigation icon is displayed only if the node is not a leaf node, regardless of whether there are currently child nodes.

In other words, I would like to have the following line in HtmlRenderer.encodeNavigation() changed from:

bitMask += (node.getChildCount()>0) ? CHILDREN : NOTHING;

to:

bitMask += (node.isLeaf) ? CHILDREN : NOTHING;

If we make this change, then the application developer has more control over whether the + navigation symbol appears, since the application developer can override the isLeaf() method in the node itself.

Currently, the workaround is to override the node's getChildCount() method to return the number of records expected if the user were to request the fetch. However, the "expected" number of records is not always known, so, in these cases, getChildCount() would have to be coded to return an arbitrary number greater than zero, which is kind of a kluge.

Issue Links

• relates to: MYFACES-382 [tree2] Do not show navigation icons if node is empty