MyFaces Core
  1. MyFaces Core
  2. MYFACES-3438

jsf.js: error handling output improvement

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.12-SNAPSHOT, 2.1.6-SNAPSHOT
    • Fix Version/s: 2.0.12, 2.1.6
    • Component/s: None
    • Labels:
      None

      Description

      While we already have improved the error reporting a lot. We still have room for improvement.
      For instance the error alert could need some room for improvement, we should also report the faulty http codes
      in case of a http error etc...
      Also we should discuss whether we really should use the alert if there is a console present. (would make more sense
      to push error reports into the console on newer browsers if present)

        Activity

        Hide
        Leonardo Uribe added a comment -

        Translation committed on 2.1.x and 2.0.x branches

        Show
        Leonardo Uribe added a comment - Translation committed on 2.1.x and 2.0.x branches
        Hide
        Keith Wong added a comment -

        Will the translation be accepted?

        Show
        Keith Wong added a comment - Will the translation be accepted?
        Hide
        Keith Wong added a comment -

        Chinese translations for the new message MSG_SERVER_ERROR_NAME

        Show
        Keith Wong added a comment - Chinese translations for the new message MSG_SERVER_ERROR_NAME
        Hide
        Werner Punz added a comment -

        I am resolving this issue now, the error reporting now is greatly improved, the http error codes are shown even in case of a 0 error code (small bug in the codebase). I leave the alert for now since it is overridable.

        Show
        Werner Punz added a comment - I am resolving this issue now, the error reporting now is greatly improved, the http error codes are shown even in case of a 0 error code (small bug in the codebase). I leave the alert for now since it is overridable.
        Hide
        Werner Punz added a comment -

        Ok with the next commit the error output will be rearranged like following screenshot shows
        https://picasaweb.google.com/100881551099991079424/NewErrorDisplay#5693800525273047490

        which means the message is the first
        everything else is below according to the priority.

        I will start to work on showing the proper http codes in case of a http error tomorrow.
        Also we need to discuss whether we should drop the error alerts in favor of console errors if a console is present.
        We currently do it only as alert because mojarra does it as well, but the spec clearly says nothing about the way the error should be presented.

        Show
        Werner Punz added a comment - Ok with the next commit the error output will be rearranged like following screenshot shows https://picasaweb.google.com/100881551099991079424/NewErrorDisplay#5693800525273047490 which means the message is the first everything else is below according to the priority. I will start to work on showing the proper http codes in case of a http error tomorrow. Also we need to discuss whether we should drop the error alerts in favor of console errors if a console is present. We currently do it only as alert because mojarra does it as well, but the spec clearly says nothing about the way the error should be presented.
        Hide
        Werner Punz added a comment -

        Ok with the next commit the error output will be rearranged like following screenshot shows
        https://picasaweb.google.com/100881551099991079424/NewErrorDisplay#5693800525273047490

        which means the message is the first
        everything else is below according to the priority.

        I will start to work on showing the proper http codes in case of a http error tomorrow.
        Also we need to discuss whether we should drop the error alerts in favor of console errors if a console is present.
        We currently do it only as alert because mojarra does it as well, but the spec clearly says nothing about the way the error should be presented.

        Show
        Werner Punz added a comment - Ok with the next commit the error output will be rearranged like following screenshot shows https://picasaweb.google.com/100881551099991079424/NewErrorDisplay#5693800525273047490 which means the message is the first everything else is below according to the priority. I will start to work on showing the proper http codes in case of a http error tomorrow. Also we need to discuss whether we should drop the error alerts in favor of console errors if a console is present. We currently do it only as alert because mojarra does it as well, but the spec clearly says nothing about the way the error should be presented.

          People

          • Assignee:
            Werner Punz
            Reporter:
            Werner Punz
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development