Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.0.12-SNAPSHOT, 2.1.6-SNAPSHOT
    • Fix Version/s: 2.0.12, 2.1.6
    • Component/s: JSR-314
    • Labels:
      None
    • Environment:
      myfaces core trunk

      Description

      use index based loop where possible, see class java.util.RandomAccess for details

      1. ApplicationImpl.patch
        1 kB
        Martin Kočí
      2. DefaultFacelet.patch
        2 kB
        Martin Kočí
      3. DefaultFaceletsStateManagementStrategy.patch
        2 kB
        Martin Kočí
      4. FacesConfigurator.patch
        1 kB
        Martin Kočí
      5. HtmlBodyRendererBase.patch
        1 kB
        Martin Kočí
      6. HtmlGridRendererBase.patch
        1 kB
        Martin Kočí
      7. HtmlLinkRendererBase.patch
        3 kB
        Martin Kočí
      8. HtmlRendererUtils.patch
        7 kB
        Martin Kočí
      9. HtmlTableRendererBase.patch
        2 kB
        Martin Kočí
      10. NavigationHandler.patch
        3 kB
        Martin Kočí
      11. UIRepeat.patch
        2 kB
        Martin Kočí
      12. HtmlHeadRenderer.patch
        1 kB
        Martin Kočí
      13. HtmlAjaxBehaviorRenderer.patch
        3 kB
        Martin Kočí
      14. FaceletCompositionContextImpl.patch
        4 kB
        Martin Kočí

        Activity

        Martin Kočí created issue -
        Martin Kočí made changes -
        Field Original Value New Value
        Component/s JSR-314 [ 12312453 ]
        Martin Kočí made changes -
        Attachment ApplicationImpl.patch [ 12509276 ]
        Attachment DefaultFacelet.patch [ 12509277 ]
        Attachment DefaultFaceletsStateManagementStrategy.patch [ 12509278 ]
        Attachment FacesConfigurator.patch [ 12509279 ]
        Attachment HtmlBodyRendererBase.patch [ 12509280 ]
        Attachment HtmlGridRendererBase.patch [ 12509281 ]
        Attachment HtmlLinkRendererBase.patch [ 12509282 ]
        Attachment HtmlRendererUtils.patch [ 12509283 ]
        Attachment HtmlTableRendererBase.patch [ 12509284 ]
        Attachment NavigationHandler.patch [ 12509285 ]
        Attachment UIRepeat.patch [ 12509286 ]
        Martin Kočí made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Martin Kočí made changes -
        Attachment HtmlHeadRenderer.patch [ 12509853 ]
        Attachment HtmlAjaxBehaviorRenderer.patch [ 12509854 ]
        Attachment FaceletCompositionContextImpl.patch [ 12509855 ]
        Hide
        Leonardo Uribe added a comment -

        I checked all patches and applied most of them. I did some small adjustments on DefaultFacelet.patch. There are some places where some methods should be private instead public.

        I think NavigationHandler.patch is not a good idea, because it changes one method signature that is part of "myfaces impl api", and the code affected is only executed once, so the improvement is microscopic compared with the trouble.

        I didn't applied HtmlAjaxBehaviorRenderer.patch, because I had planned to rewrite that renderer in a way that does not use so many StringBuilder instances, so I'll keep in mind those changes to include them later.

        Thanks to Martin Koci for provide these patches.

        Show
        Leonardo Uribe added a comment - I checked all patches and applied most of them. I did some small adjustments on DefaultFacelet.patch. There are some places where some methods should be private instead public. I think NavigationHandler.patch is not a good idea, because it changes one method signature that is part of "myfaces impl api", and the code affected is only executed once, so the improvement is microscopic compared with the trouble. I didn't applied HtmlAjaxBehaviorRenderer.patch, because I had planned to rewrite that renderer in a way that does not use so many StringBuilder instances, so I'll keep in mind those changes to include them later. Thanks to Martin Koci for provide these patches.
        Leonardo Uribe made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Fix Version/s 2.0.12 [ 12319175 ]
        Fix Version/s 2.1.6 [ 12319173 ]
        Resolution Fixed [ 1 ]
        Leonardo Uribe made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Martin Kočí
            Reporter:
            Martin Kočí
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development