MyFaces Core
  1. MyFaces Core
  2. MYFACES-3431

jsf.js: minor spec implementation bug, success is sent at the wrong location of the code

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.11, 2.1.5
    • Fix Version/s: 2.0.12, 2.1.6
    • Component/s: None
    • Labels:
      None

      Description

      The spec jsdoc states following in the section for jsf.ajax.response:

      If the response was successfully processed, send a success event as outlined in Chapter 13 "Sending Events" section of the spec prose document linked in the overview summary.

      This means, the jsf.ajax.response is responsible for sending the success event. For now we are sending it from the ajaxrequest response handler.
      This needs to be fixed.

        Activity

        Werner Punz created issue -
        Hide
        Werner Punz added a comment -

        We also need to investigate if this applies to onError as well, since our entire error handling currently happens outside of jsf.ajax.response

        Show
        Werner Punz added a comment - We also need to investigate if this applies to onError as well, since our entire error handling currently happens outside of jsf.ajax.response
        Hide
        Werner Punz added a comment -

        fixed, i will try to add a testcase for this issue to my testsuite

        Show
        Werner Punz added a comment - fixed, i will try to add a testcase for this issue to my testsuite
        Werner Punz made changes -
        Field Original Value New Value
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 2.0.12-SNAPSHOT [ 12319174 ]
        Fix Version/s 2.1.6-SNAPSHOT [ 12319172 ]
        Resolution Fixed [ 1 ]
        Leonardo Uribe made changes -
        Fix Version/s 2.0.12 [ 12319175 ]
        Fix Version/s 2.1.6 [ 12319173 ]
        Fix Version/s 2.1.6-SNAPSHOT [ 12319172 ]
        Fix Version/s 2.0.12-SNAPSHOT [ 12319174 ]
        Leonardo Uribe made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Werner Punz
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development