MyFaces Core
  1. MyFaces Core
  2. MYFACES-3427

[perf] Use only one StringBuilder for generate unique facelets identifiers

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.12, 2.1.6
    • Component/s: None
    • Labels:
      None

      Description

      The code that generate unique identifiers, like UIComponentBase.getClientId() and others inside facelets are operations that are called very frequent, so it is necessary to ensure that code is as fast as possible and use few memory resources

      Also, doing some performance tests I notice Long.toString(long, radix) is too expensive. It creates a lot of unnecessary String objects.

      In practice, we should prevent create object instances in such locations, and use only one StringBuffer if possible.

        Activity

        Leonardo Uribe created issue -
        Leonardo Uribe made changes -
        Field Original Value New Value
        Attachment MYFACES-3427-1.patch [ 12510772 ]
        Leonardo Uribe made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Leonardo Uribe made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Leonardo Uribe made changes -
        Attachment MYFACES-3427-1.patch [ 12510772 ]
        Leonardo Uribe made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 2.0.12 [ 12319175 ]
        Fix Version/s 2.1.6 [ 12319173 ]
        Resolution Fixed [ 1 ]
        Leonardo Uribe made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Leonardo Uribe
            Reporter:
            Leonardo Uribe
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development