MyFaces Core
  1. MyFaces Core
  2. MYFACES-3361

jsf.js: code restructuration for size and speed improvlements

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.10-SNAPSHOT, 2.1.4-SNAPSHOT
    • Fix Version/s: 2.0.10, 2.1.4
    • Component/s: None
    • Labels:
      None

      Description

      Currently we have one big jsf.js file with all code in

      • core which implements all of the spec
      • i18n which implements the language messages for currently 7 languages
      • experimental which implements features targetted for jsf 2.2 onwards
      • quirksmode code which supports non standard compliant browsers

      The idea is to still keep one big file, but also provide several files which partially can be mixed to achieve the functionality needed

      We are going to allow

      • one big file which resembles our current jsf.js
      • a base file which resembles the core + quirksmode
      • a modern browser file which resembles the core only without quirksmode code
      • a separate i18n file for the i18n messages
      • a legacy file for quirksmode browsers
      • an experimental file with all non standard features combined
        In the end the plan is to allow the users to mix those feature sets to reduce the import size while still retaining all the existing
        functionality.

        Activity

        Werner Punz created issue -
        Werner Punz made changes -
        Field Original Value New Value
        Description h2. Currently we have one big jsf.js file with all code in

        * *core* which implements all of the spec
        * *i18n* which implements the language messages for currently 7 languages
        * *experimental* which implements features targetted for jsf 2.2 onwards
        * *quirksmode* code which supports non standard compliant browsers

        The idea is to still keep one big file, but also provide several files which partially can be mixed to achieve the functionality needed

        We are going to allow

        * one big file which resembles our current jsf.js
        * a base file which resembles the core + quirksmode
        * a modern browser file which resembles the core only without quirksmode code
        * a separate i18n file for the i18n messages
        * a legacy file for quirksmode browsers
        * an experimental file with all non standard features combined

        h2. In the end the plan is to allow the users to mix those feature sets to reduce the import size while still retaining all the existing
        functionality.

        h2. Currently we have one big jsf.js file with all code in

        * *core* which implements all of the spec
        * *i18n* which implements the language messages for currently 7 languages
        * *experimental* which implements features targetted for jsf 2.2 onwards
        * *quirksmode* code which supports non standard compliant browsers

        The idea is to still keep one big file, but also provide several files which partially can be mixed to achieve the functionality needed


        h2. We are going to allow

        * one big file which resembles our current jsf.js
        * a base file which resembles the core + quirksmode
        * a modern browser file which resembles the core only without quirksmode code
        * a separate i18n file for the i18n messages
        * a legacy file for quirksmode browsers
        * an experimental file with all non standard features combined
         In the end the plan is to allow the users to mix those feature sets to reduce the import size while still retaining all the existing
        functionality.

        Werner Punz made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Werner Punz added a comment -

        Patches to the core to enable the web.xml config params

        Show
        Werner Punz added a comment - Patches to the core to enable the web.xml config params
        Werner Punz made changes -
        Attachment Adding_modular_jsf_js_support_.patch [ 12499859 ]
        Hide
        Leonardo Uribe added a comment -

        I checked the patch and fixed some parts, because InternalClassLoaderResourceLoader was thought jus as a workaround. Thanks Werner for the patch.

        Show
        Leonardo Uribe added a comment - I checked the patch and fixed some parts, because InternalClassLoaderResourceLoader was thought jus as a workaround. Thanks Werner for the patch.
        Leonardo Uribe made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Assignee Leonardo Uribe [ lu4242 ]
        Fix Version/s 2.0.10 [ 12317870 ]
        Fix Version/s 2.1.4 [ 12317868 ]
        Resolution Fixed [ 1 ]
        Hide
        Werner Punz added a comment -

        I also want to split the RT into a Core RT and a quirks RT so that we can isolate legacy browser specific code from the RT and remove it for our minimal-modern build.

        Show
        Werner Punz added a comment - I also want to split the RT into a Core RT and a quirks RT so that we can isolate legacy browser specific code from the RT and remove it for our minimal-modern build.
        Werner Punz made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Assignee Leonardo Uribe [ lu4242 ] Werner Punz [ werpu ]
        Werner Punz made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Werner Punz added a comment -

        Reopening for another bunch of refactorings which reduces the code size for the core again another kbytes.

        Show
        Werner Punz added a comment - Reopening for another bunch of refactorings which reduces the code size for the core again another kbytes.
        Werner Punz made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Hide
        Werner Punz added a comment -

        resolved for now, I will give the entire new structure a proper testing next week, and then off to the documentation.

        Show
        Werner Punz added a comment - resolved for now, I will give the entire new structure a proper testing next week, and then off to the documentation.
        Werner Punz made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Keith Wong added a comment -

        It seems Messages_zh_HK.js is missing in the change set #1190363 and #1190364.

        Show
        Keith Wong added a comment - It seems Messages_zh_HK.js is missing in the change set #1190363 and #1190364.
        Hide
        Werner Punz added a comment -

        Hi Keith, thanks for reporting it, I will fix that tomorrow.

        Show
        Werner Punz added a comment - Hi Keith, thanks for reporting it, I will fix that tomorrow.
        Hide
        Werner Punz added a comment -

        reopening issue because the honkong chinese messages are missing in the final build

        Show
        Werner Punz added a comment - reopening issue because the honkong chinese messages are missing in the final build
        Werner Punz made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Hide
        Werner Punz added a comment -

        we are done with it for this release

        Show
        Werner Punz added a comment - we are done with it for this release
        Werner Punz made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Werner Punz added a comment -
        Show
        Werner Punz added a comment - I added a blog for the new functionality: http://www.irian.at/de/blog/-/blogs/introducing-apache-myfaces-modular-includes
        Leonardo Uribe made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        1d 23h 51m 1 Werner Punz 20/Oct/11 15:19
        Patch Available Patch Available Resolved Resolved
        7h 30m 1 Leonardo Uribe 20/Oct/11 22:49
        Resolved Resolved Reopened Reopened
        11d 9h 15m 3 Werner Punz 01/Nov/11 07:16
        Reopened Reopened Resolved Resolved
        7d 10h 19m 3 Werner Punz 08/Nov/11 17:25
        Resolved Resolved Closed Closed
        7d 7h 57m 1 Leonardo Uribe 16/Nov/11 01:22

          People

          • Assignee:
            Werner Punz
            Reporter:
            Werner Punz
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development