MyFaces Core
  1. MyFaces Core
  2. MYFACES-3332

Fix condition to call ComponentSupport.markComponentToRestoreFully on 2.1.x branch

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.1.4
    • Component/s: JSR-314
    • Labels:
      None

      Description

      Since JSF 2.1, after the view is built an addtional iteration to call markInitialState is done.

      The condition to call ComponentSupport.markComponentToRestoreFully relies on that value, but instead we should use this condition:

      fcc.isRefreshTransientBuildOnPSS() && !fcc.isRefreshingTransientBuild()

      If no refreshing is done we are creating a new view, just like markInitialState. The effect is the view is not refreshed automatically in "auto" mode. It has been reported earlier, but checking the patch done on MYFACES-3329 I realized this condition is not working as expected.

        Issue Links

          Activity

          Leonardo Uribe created issue -
          Leonardo Uribe made changes -
          Field Original Value New Value
          Link This issue is part of MYFACES-3329 [ MYFACES-3329 ]
          Hide
          Leonardo Uribe added a comment -

          I'll fix this one together with the patch for MYFACES-3329

          Show
          Leonardo Uribe added a comment - I'll fix this one together with the patch for MYFACES-3329
          Leonardo Uribe made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Fix Version/s 2.1.4 [ 12317868 ]
          Resolution Fixed [ 1 ]
          Leonardo Uribe made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Leonardo Uribe
              Reporter:
              Leonardo Uribe
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development