MyFaces Core
  1. MyFaces Core
  2. MYFACES-3295

Replace RendererUtils.renderChild() by UIComponent.encodeAll()

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.9, 2.1.3
    • Component/s: JSR-314
    • Labels:
      None

      Description

      Checking other issues, if was notice that RendererUtils.renderChild() is almost equal to UIComponent.encodeAll().

      Historically, RendererUtils.renderChild() is older than UIComponent.encodeAll(), but the later one is better because gives the chance to the component to override it.

      It is known any override goes on encodeBegin(), encodeChildren() or encodeEnd(), but to honor JSF 2.0 spec, we should fix RendererUtils.renderChildren(), and use encodeAll() instead RendererUtils.renderChild().

        Activity

        Hide
        Martin Kočí added a comment -

        +1 ! During this please consider semi-related issue MYFACES-3198. Current solution with RendererUtils.renderChild() prevents to queue UIComponent which caused the exception, because exception from RendererUtils.renderChild() (used inrenderer) is propagated to parent component.

        Show
        Martin Kočí added a comment - +1 ! During this please consider semi-related issue MYFACES-3198 . Current solution with RendererUtils.renderChild() prevents to queue UIComponent which caused the exception, because exception from RendererUtils.renderChild() (used inrenderer) is propagated to parent component.

          People

          • Assignee:
            Leonardo Uribe
            Reporter:
            Leonardo Uribe
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development