MyFaces Core
  1. MyFaces Core
  2. MYFACES-3278

ResourceHandler implementation should take into account UIViewRoot locale to load a resource

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.8, 2.1.2
    • Component/s: JSR-314
    • Labels:
      None

      Description

      The spec has a problem when it try to derive which resource should be resolved according to a locale.

      All start on JSF 2.0 section 2.6.1.4. There is some pseudo code that says this:

      function getLocalePrefix() {
      var localePrefix;
      var appBundleName = facesContext.application.messageBundle;
      if (null != appBundleName)

      { var locale = facesContext.application.viewHandler.calculateLocale(); ResourceBundle appBundle = ResourceBundle.getBundle( appBundleName, locale); localePrefix = appBundle.getString(ResourceHandler. LOCALE_PREFIX); }

      // Any MissingResourceException instances that are encountered
      // in the above code must be swallowed by this method, and null
      // returned;
      return localePrefix;
      }

      The problem start when to calculate the locale using facesContext.application.viewHandler.calculateLocale(). The description on the javadoc about this method says this:

      "... Returns an appropriate Locale to use for this and subsequent requests for the current client...."

      Ok. Now look spec section 7.5.1. :

      public Locale calculateLocale(FacesContext context);
      public String calculateRenderKitId(FacesContext context);

      "... These methods are called from createView() to allow the new view to determine the Locale to be used for all subsequent requests, and to find out which renderKitId should be used for rendering the view. ..."

      On "view" requests, when ViewHandler.createView() is called, calculateLocale() is called too and the locale is assigned to the viewRoot through UIViewRoot.setLocale(). Later, facelets ViewHandler or jsf ViewTag can override this value using an static string or a ValueExpression.

      But, if the current request is a "resource" request, no viewRoot will be found, so calculateLocale() should be done. In this case the locale should be extracted in some way from the request path.

      Doing some tests it seems Mojarra guys thought the same too, because they append a &loc=... for each resource, but that param is broken, because it is ignored when it is loaded. Anyway, it seems to be the way to go. Other minor changes will be committed too.

        Activity

        There are no comments yet on this issue.

          People

          • Assignee:
            Leonardo Uribe
            Reporter:
            Leonardo Uribe
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development