MyFaces Core
  1. MyFaces Core
  2. MYFACES-3255

UICommand.queueEvent description changed since 2.0

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.2.11, 2.0.8, 2.1.2
    • Component/s: None
    • Labels:
      None

      Description

      Checking some javadoc for JSF 2.2 "viewAction", I notice our implementation of UICommand.queueEvent does not match with the documentation since JSF 2.0.

      Before:

      public void queueEvent(FacesEvent e)

      Intercept queueEvent and, for ActionEvents, mark the phaseId for the event to be PhaseId.APPLY_REQUEST_VALUES if the immediate flag is true, PhaseId.INVOKE_APPLICATION otherwise.

      After:

      public void queueEvent(FacesEvent e)

      Intercept queueEvent and take the following action. If the event is an ActionEvent, obtain the UIComponent instance from the event. If the component is an ActionSource obtain the value of its "immediate" property. If it is true, mark the phaseId for the event to be PhaseId.APPLY_REQUEST_VALUES otherwise, mark the phaseId to be PhaseId.INVOKE_APPLICATION. The event must be passed on to super.queueEvent() before returning from this method.

      Tracking this one I found this issue:

      http://java.net/jira/browse/JAVASERVERFACES-622

      Since it was added after 1.2 rev A and before 2.0, myfaces code still does what the spec says since 1.2. Anyway, we should change MyFaces code to follow the javadoc description.

        Activity

        Leonardo Uribe created issue -
        Leonardo Uribe made changes -
        Field Original Value New Value
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 1.2.11 [ 12316650 ]
        Fix Version/s 2.0.8 [ 12316514 ]
        Fix Version/s 2.1.2 [ 12316512 ]
        Resolution Fixed [ 1 ]
        Leonardo Uribe made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Leonardo Uribe
            Reporter:
            Leonardo Uribe
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development