[MYFACES-3216] check concurrency problems over static maps holding class metadata information (_ComponentAttributesMap and MetaRulesetImpl) - ASF JIRA

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: None
Fix Version/s: 1.2.11, 2.0.8, 2.1.2
Component/s: JSR-314
Labels:
None

Description

There is something suspicious about these two maps:

javax.faces.component._ComponentAttributesMap

// Cache for component property descriptors
private static Map<Class<?>, Map<String, PropertyDescriptor>> _propertyDescriptorCache =
new WeakHashMap<Class<?>, Map<String, PropertyDescriptor>>();

org.apache.myfaces.view.facelets.tag

private final static WeakHashMap<ClassLoader, Map<String, MetadataTarget>> _metadata
= new WeakHashMap<ClassLoader, Map<String, MetadataTarget>>();

Both maps do something similar, cache PropertyDescriptor and other information that is unique per class. The problem is WeakHashMap is not thread safe, so in both cases there is a potential risk of throw exceptions when calling "put" method under high load.

The solution is put proper synchronized blocks when calling to put is done, just like FactoryFinder does.

Reported stack trace by Rajadurai_p. See http://markmail.org/message/4md2rsiii5mjhvcr?q=MyFaces+-+Thread+issues+under+High+load for details:

Hi,

we are facing problems in MyFaces framework under high load. Bulk of the
application container threads (weblogic) are stuck upon a same stack trace.
I have pasted a sample stack trace below. Kindly help.

We use JSF 1.2, MyFaces 1.2.9, Tomahawk 1.1.9 & RichFaces 3.3.3.

java.beans.PropertyDescriptor.getReadMethod(PropertyDescriptor.java:158)

javax.faces.component._ComponentAttributesMap.getComponentProperty(_ComponentAttributesMap.java:382)

javax.faces.component._ComponentAttributesMap.get(_ComponentAttributesMap.java:227)

org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlRendererUtils.renderHTMLAttribute(HtmlRendererUtils.java:584)

org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlRendererUtils.renderHTMLAttributes(HtmlRendererUtils.java:598)

org.apache.myfaces.custom.htmlTag.HtmlTagRenderer.encodeBegin(HtmlTagRenderer.java:73)
javax.faces.component.UIComponentBase.encodeBegin(UIComponentBase.java:600)

org.apache.myfaces.shared_tomahawk.renderkit.RendererUtils.renderChild(RendererUtils.java:525)

org.apache.myfaces.shared_tomahawk.renderkit.RendererUtils.renderChildren(RendererUtils.java:511)

org.apache.myfaces.custom.htmlTag.HtmlTagRenderer.encodeChildren(HtmlTagRenderer.java:111)

javax.faces.component.UIComponentBase.encodeChildren(UIComponentBase.java:627)

org.apache.myfaces.shared_tomahawk.renderkit.RendererUtils.renderChild(RendererUtils.java:528)

org.apache.myfaces.shared_tomahawk.renderkit.RendererUtils.renderChildren(RendererUtils.java:511)

org.apache.myfaces.custom.htmlTag.HtmlTagRenderer.encodeChildren(HtmlTagRenderer.java:111)

javax.faces.component.UIComponentBase.encodeChildren(UIComponentBase.java:627)
org.ajax4jsf.renderkit.RendererBase.renderChild(RendererBase.java:277)
org.ajax4jsf.renderkit.RendererBase.renderChildren(RendererBase.java:258)

org.richfaces.renderkit.AbstractGridRenderer.encodeOneRow(AbstractGridRenderer.java:96)

org.richfaces.renderkit.AbstractRowsRenderer.process(AbstractRowsRenderer.java:83)
org.ajax4jsf.model.SequenceDataModel.walk(SequenceDataModel.java:101)
org.ajax4jsf.component.UIDataAdaptorBase.walk(UIDataAdaptorBase.java:1156)

org.richfaces.renderkit.AbstractRowsRenderer.encodeRows(AbstractRowsRenderer.java:104)

org.richfaces.renderkit.AbstractRowsRenderer.encodeRows(AbstractRowsRenderer.java:88)

org.richfaces.renderkit.AbstractRowsRenderer.encodeChildren(AbstractRowsRenderer.java:137)

javax.faces.component.UIComponentBase.encodeChildren(UIComponentBase.java:627)
org.ajax4jsf.renderkit.RendererBase.renderChild(RendererBase.java:277)
org.ajax4jsf.renderkit.RendererBase.renderChildren(RendererBase.java:258)

org.ajax4jsf.renderkit.html.AjaxOutputPanelRenderer.encodeChildren(AjaxOutputPanelRenderer.java:78)

javax.faces.component.UIComponentBase.encodeChildren(UIComponentBase.java:627)

org.apache.myfaces.shared_tomahawk.renderkit.RendererUtils.renderChild(RendererUtils.java:528)

org.apache.myfaces.shared_tomahawk.renderkit.RendererUtils.renderChildren(RendererUtils.java:511)

org.apache.myfaces.custom.htmlTag.HtmlTagRenderer.encodeChildren(HtmlTagRenderer.java:111)

javax.faces.component.UIComponentBase.encodeChildren(UIComponentBase.java:627)
javax.faces.component.UIComponent.encodeAll(UIComponent.java:250)

com.sun.facelets.component.RepeatRenderer.encodeChildren(RepeatRenderer.java:64)
com.sun.facelets.component.UIRepeat.process(UIRepeat.java:423)
com.sun.facelets.component.UIRepeat.encodeChildren(UIRepeat.java:684)
org.ajax4jsf.renderkit.RendererBase.renderChild(RendererBase.java:277)
org.ajax4jsf.renderkit.RendererBase.renderChildren(RendererBase.java:258)

org.richfaces.renderkit.html.PanelRenderer.doEncodeChildren(PanelRenderer.java:200)

org.richfaces.renderkit.html.PanelRenderer.doEncodeChildren(PanelRenderer.java:195)
org.ajax4jsf.renderkit.RendererBase.encodeChildren(RendererBase.java:120)

javax.faces.component.UIComponentBase.encodeChildren(UIComponentBase.java:627)
org.ajax4jsf.renderkit.RendererBase.renderChild(RendererBase.java:277)
org.ajax4jsf.renderkit.RendererBase.renderChildren(RendererBase.java:258)
org.ajax4jsf.renderkit.RendererBase.renderChild(RendererBase.java:279)
org.ajax4jsf.renderkit.RendererBase.renderChildren(RendererBase.java:258)