MyFaces Core
  1. MyFaces Core
  2. MYFACES-3053 Improve error reporting and logging
  3. MYFACES-3214

Remove exception wrapping with FacesException and with getPathToComponent

    Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.8, 2.1.2
    • Component/s: General
    • Labels:
      None

      Description

      some old code uses:

      catch(Exception ex)

      { throw new FacesException("Could not retrieve value of component with path : "+ getPathToComponent(component),ex); }

      to provide path to problematic component. With JSF 2.0 and exception handler is is not necessary (and only makes stacktrace harder to read), because:
      1) exception is always queued with component instance (see MYFACES-3201)
      2) every EL expression knows about it's location (MYFACES-3202)

        Activity

        Martin Kočí created issue -
        Martin Kočí made changes -
        Field Original Value New Value
        Component/s General [ 12310160 ]
        Hide
        Martin Kočí added a comment -

        patch - removes rethrow from decode and validate phase - will be replaced consistently with MYFACES-3201

        Show
        Martin Kočí added a comment - patch - removes rethrow from decode and validate phase - will be replaced consistently with MYFACES-3201
        Martin Kočí made changes -
        Attachment MYFACES-3214.patch [ 12486180 ]
        Martin Kočí made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Leonardo Uribe added a comment -

        Yes, it sounds like some leftover from JSF 1.2

        Show
        Leonardo Uribe added a comment - Yes, it sounds like some leftover from JSF 1.2
        Leonardo Uribe made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Assignee Leonardo Uribe [ lu4242 ]
        Fix Version/s 2.0.8 [ 12316514 ]
        Fix Version/s 2.1.2 [ 12316512 ]
        Resolution Fixed [ 1 ]
        Leonardo Uribe made changes -
        Assignee Leonardo Uribe [ lu4242 ] Martin Kočí [ markoc50 ]
        Leonardo Uribe made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Martin Kočí
            Reporter:
            Martin Kočí
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development