MyFaces Core
  1. MyFaces Core
  2. MYFACES-3053 Improve error reporting and logging
  3. MYFACES-3207

ErrorPageWriter: provide info about component(s) that triggered the problem

    Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.8, 2.1.2
    • Component/s: General
    • Labels:
      None

      Description

      "any time there is an error in any part of the lifecycle, the user should see not just a cryptic stack trace, but also the component - that triggered the problem" - from MYFACES-3053

      Currently ErrorPageWriter does not output info source component, although component in the most important class in JSF.

      1. MYFACES-3207-v3.patch
        12 kB
        Leonardo Uribe
      2. MYFACES-3207-v2.patch
        11 kB
        Martin Kočí
      3. MYFACES-3207.patch
        9 kB
        Martin Kočí
      4. ASF.LICENSE.NOT.GRANTED--screenshot-patch-v3.jpg
        195 kB
        Leonardo Uribe

        Activity

        Hide
        Martin Kočí added a comment -

        patch adds:
        1) viewId, location and phaseId in header
        2) info about components
        3) first line of stackTraceElement (user doesn't need to expand stack trace section)
        4) highlighting of component in tree

        please notice that this does not work because myfaces don't queue source component with exception: MYFACES-3201

        Show
        Martin Kočí added a comment - patch adds: 1) viewId, location and phaseId in header 2) info about components 3) first line of stackTraceElement (user doesn't need to expand stack trace section) 4) highlighting of component in tree please notice that this does not work because myfaces don't queue source component with exception: MYFACES-3201
        Hide
        Martin Kočí added a comment -

        patch updated: added param for method _writeComponent for write/don't write children

        Show
        Martin Kočí added a comment - patch updated: added param for method _writeComponent for write/don't write children
        Hide
        Leonardo Uribe added a comment - - edited

        Screenshot of patch modified to v3

        Show
        Leonardo Uribe added a comment - - edited Screenshot of patch modified to v3
        Hide
        Leonardo Uribe added a comment -

        The patch proposed is nice stuff. I have updated the patch provided and I did some small changes, in the locations where the info should be. See the screenshot provided. If you agree I'll commit the patch. If no objections I'll commit the patch soon.

        Show
        Leonardo Uribe added a comment - The patch proposed is nice stuff. I have updated the patch provided and I did some small changes, in the locations where the info should be. See the screenshot provided. If you agree I'll commit the patch. If no objections I'll commit the patch soon.
        Hide
        Jakob Korherr added a comment -

        looks really nice! +1

        Show
        Jakob Korherr added a comment - looks really nice! +1

          People

          • Assignee:
            Martin Kočí
            Reporter:
            Martin Kočí
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development