Attach filesAttach ScreenshotVotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 2.0.9, 2.1.3
    • General
    • None

    Description

      From MYFACES-3053 "user should see not just a cryptic stack trace, but the EL expression that was being evaluated including the part of the EL expression that triggered the problem"

      Myfaces utilize TagValueExpression and TagValueExpressionUEL as TagAtrribute-aware wrappers around EL ValueExpression. But this "context" is only .toString() of TagAttribute and that prohibits user-frendly formatting of messages.

      Provide TagAttribute instance, create TagAttributeAwareExceptionWrapper that will hold this instance. Clients (mainly ErrorPage) can read attributes of TagAttribute and format it as necessary, for example "EL expression that triggered the problem: " + wrapper.getTagAttribute().getValue()

      Attachments

        1. MYFACES-3202.patch
          19 kB
          Martin Kočí
        2. MYFACES-3202-ErrorPageWriter.patch
          3 kB
          Martin Kočí
        3. MYFACES-3202-screenshot.png
          169 kB
          Martin Kočí
        4. MYFACES-3202-v2.patch
          32 kB
          Martin Kočí

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            markoc50 Martin Kočí
            markoc50 Martin Kočí
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment